Better C++ compatibility for branch fast_lio #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add missing std:: namespace qualifiers. remove unistd.h include which is only necessary for usleep but not available on all platforms. implement usleep with c++ std libraries <thread> and <chrono>.
Author
|
Using <pthread.h> is sometimes also problematic to build on certain platforms and can be replaced by std::thread and std::mutex. |
pthread_mutex_trylock returns zero on success. std::mutex::try_lock returns true on success. The conditions checked for success of pthread_mutex_trylock, so they should now require result value of `true`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22
Right now the header file is "using namespace std". This is considered bad practice, but easy to fix.
Additionally <unistd.h> is used to put the current thread to sleep.
This is not platform independent, but easily replaced by C++ std library functionality.