Skip to content

Conversation

@workbysaran
Copy link
Contributor

@workbysaran workbysaran commented Oct 27, 2025

Resolved / Related Issues
Fixed an issue where using Column View in the Recycle Bin caused unexpected behavior with file system hierarchy display. The Columns layout is now disabled when viewing the Recycle Bin to prevent navigation issues.

Closes #13654

Steps used to test these changes

  1. Open the Files app and navigate to any folder
  2. Delete some folders to create test items in Recycle Bin
  3. Navigate to the Recycle Bin
  4. Open the Layout options menu from the toolbar
  5. Verify that the Columns layout button is grayed out and disabled
  6. Try using the keyboard shortcut (Ctrl+Shift+5) and verify it doesn't switch to Columns view
  7. Switch to other layouts (Details, List, Cards, Grid) and verify they work normally in Recycle Bin
  8. Navigate away from Recycle Bin to any regular folder
  9. Verify that the Columns layout button is now enabled and functional again
  10. Navigate back to Recycle Bin and confirm Columns layout is disabled again

… unexpected behavior with file system hierarchy display. The Columns layout is now disabled when viewing the Recycle Bin to prevent navigation issues.
@yaira2
Copy link
Member

yaira2 commented Oct 27, 2025

@workbysaran what happens if the user has the 'sync layout preferences' option enabled and has the default layout set to Columns?

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Oct 27, 2025
@workbysaran
Copy link
Contributor Author

I have updated the LayoutPreferencesManager to handle the scenario when the "Sync layout preferences" setting is enabled.

… unexpected behavior with file system hierarchy display. The Columns layout is now disabled when viewing the Recycle Bin to prevent navigation issues.
@yaira2 yaira2 force-pushed the sg/fix-disable-collayout-recyclebin branch from cbc4965 to bb070b0 Compare October 28, 2025 14:25
@yaira2
Copy link
Member

yaira2 commented Oct 28, 2025

Thanks! Does this PR supersede #17792?

@yaira2
Copy link
Member

yaira2 commented Oct 28, 2025

I found a scenario where Recycle Bin still uses Columns:

  1. Install Files (fresh install)
  2. Open Settings
  3. Change default layout to Columns (without enabling syncing)
  4. Open Recycle Bin
  5. Notice how it uses Columns

@yaira2 yaira2 changed the title Fix: Fixed an issue where using Column View in the Recycle Bin cause… Fix: Fixed an issue where Columns View was incorrectly enabled for Recycle Bin Oct 28, 2025
@workbysaran
Copy link
Contributor Author

Thanks! Does this PR supersede #17792?

Yes, it does!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Treat Recycle Bin as root when opening in Column View

2 participants