Skip to content

Feature: Added experimental terminal integration #13631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 79 commits into
base: main
Choose a base branch
from
Draft

Feature: Added experimental terminal integration #13631

wants to merge 79 commits into from

Conversation

@gave92
Copy link
Member

@gave92 gave92 commented Nov 1, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add terminal Integration #6235

Validation
How did you test these changes?

  • Did you build the app and test your changes?

Screenshots (optional)
image

@files-community files-community locked and limited conversation to collaborators Nov 1, 2023
@yaira2 yaira2 force-pushed the main branch 2 times, most recently from ff65c93 to 8097ba8 Compare July 17, 2024 15:22
Lamparter
Lamparter approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Lamparter Lamparter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the merge conflicts, what's stopping this from being merged? Was there something else to implement or is it not stable enough?

@yaira2
Copy link
Member

yaira2 commented Oct 27, 2024

Functionality wise this is pretty much good to go, but we haven't settled on a design yet.

@Josh65-2201 Josh65-2201 mentioned this pull request Feb 6, 2025
Closed
@yaira2 yaira2 force-pushed the main branch 7 times, most recently from 30cea65 to decf3da Compare March 24, 2025 21:33
@yaira2 yaira2 force-pushed the main branch 2 times, most recently from 75d29b5 to aa7d7fa Compare April 22, 2025 22:33
@yaira2 yaira2 force-pushed the main branch 2 times, most recently from 42c8207 to 4c7493f Compare July 6, 2025 15:16
@yaira2 yaira2 force-pushed the main branch 2 times, most recently from 97999e5 to 806f922 Compare September 9, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 left review comments

+4 more reviewers

@gumbarros gumbarros gumbarros left review comments

@0x5bfa 0x5bfa 0x5bfa left review comments

@XTorLukas XTorLukas XTorLukas requested changes

@Lamparter Lamparter Lamparter approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@yaira2 yaira2

Labels

ready for review Pull requests that are ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Add terminal Integration

7 participants

@gave92 @hez2010 @0x5bfa @yaira2 @gumbarros @Lamparter @XTorLukas