Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions sqlmodel/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ def __init__(self, default: Any = Undefined, **kwargs: Any) -> None:
raise RuntimeError(
"Passing sa_type is not supported when also passing a sa_column"
)
if not hasattr(PydanticFieldInfo, "validation_alias"):
kwargs.pop("validation_alias")
if not hasattr(PydanticFieldInfo, "serialization_alias"):
kwargs.pop("serialization_alias")
Comment on lines +163 to +166

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look necessary (PydanticFieldInfo seems to accept kwargs even if it doesn't use them later)

if ondelete is not Undefined:
if foreign_key is Undefined:
raise RuntimeError("ondelete can only be used with foreign_key")
Expand Down Expand Up @@ -215,6 +219,8 @@ def Field(
*,
default_factory: Optional[NoArgAnyCallable] = None,
alias: Optional[str] = None,
validation_alias: Optional[str] = None,
serialization_alias: Optional[str] = None,
title: Optional[str] = None,
description: Optional[str] = None,
exclude: Union[
Expand Down Expand Up @@ -260,6 +266,8 @@ def Field(
*,
default_factory: Optional[NoArgAnyCallable] = None,
alias: Optional[str] = None,
validation_alias: Optional[str] = None,
serialization_alias: Optional[str] = None,
title: Optional[str] = None,
description: Optional[str] = None,
exclude: Union[
Expand Down Expand Up @@ -349,6 +357,8 @@ def Field(
*,
default_factory: Optional[NoArgAnyCallable] = None,
alias: Optional[str] = None,
validation_alias: Optional[str] = None,
serialization_alias: Optional[str] = None,
title: Optional[str] = None,
description: Optional[str] = None,
exclude: Union[
Expand Down Expand Up @@ -391,6 +401,8 @@ def Field(
default,
default_factory=default_factory,
alias=alias,
validation_alias=validation_alias,
serialization_alias=serialization_alias,
title=title,
description=description,
exclude=exclude,
Expand Down