Adding embeddings results #47
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganler
reviewed
Jun 12, 2024
Member
ganler
left a comment
ganler
left a comment
There was a problem hiding this comment.
did a quick review. will check details again later
repoqa/provider/embeddings/openai.py
Outdated
| from typing import List, Tuple | ||
|
|
||
| from openai import Client | ||
| from sklearn.metrics.pairwise import cosine_similarity |
Member
There was a problem hiding this comment.
sklearn is a bit huge. ideally we want some lighter dependencies (avoiding the risk of dep conflicts in the future) or just impl the function ourselves.
repoqa/search_needle_function.py
Outdated
| trust_remote_code: bool = False, | ||
| attn_implementation=None, | ||
| is_embedding: bool = False, | ||
| embedding_context_chunk_size: int = 30 |
Member
There was a problem hiding this comment.
is this # of chunks or # tokens for each chunk? better make it more explicit :)
also i think specifying the size /#token of each chunk might be more intuitive
Collaborator
Author
There was a problem hiding this comment.
Currently it's lines of code per chunk, will change the variable name
…arn for cosine similarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.