Clean testing on a clean up test corpus #198
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved all real failures in the test. A few real failures were linked to multiline string parsing: after replacing the regex with a new token in the scanner, all parses are correct.
While at it, also resolved the bug with nesting block comments. Closes #78
About 50 files were elm 0.18 or syntax errors. Checked each one individually on Elm 0.19 compiler. Blacklisted those files in
expected_fails.txt. The existingparse-examples-fullwill probably report 51 error since it doesn't know about the blacklist.Finally, I cleaned up the test corpus: instead of downloading each repo and risking that something changes, I moved all
.elmfiles and licenses into a clean repo. This gives us a stable test inputs. I've added a new scriptparse-test-corpusthat works on that corpus, and the corresponding workflow actiontest-on-test-corpus.yml.If you agree with that new workflow, it obsoletes a bunch of test scripts that I can delete in another PR.
The test files are presently in my GitHub account, but I'd like to move that repo over to
elm-toolingif you're ok with that.