Fix ANRs and concurrency issues during TTS initialization #594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses critical bugs in FlutterTtsPlugin’s cold-start path:
1. ConcurrentModificationException
Root cause:
Iterating pendingMethodCalls while clearing it under the same lock.
Fix:
Copy the list under synchronized, clear the original, then invoke the copy outside the lock.
2. ANRs on TextToSpeech.defaultVoice / getVoices() / setLanguage()
Root cause:
Binder IPC and Java deserialization (ObjectInputStream / Voice.) were happening synchronously on the main (UI) thread during OnInitListener.
Fix:
Call engineResult.success(1) (or .error()) immediately on the UI thread so Flutter is unblocked.
Spawn a short‐lived Thread { … } to perform all heavy TTS service calls (tts.defaultVoice, tts.setLanguage, voice enumeration) off the Looper.
Applied consistently in both onInitListenerWithCallback and onInitListenerWithoutCallback.
Had several ANR and crash reports:
🚨 Crash Report (click to expand)
🚨 ANR Report (click to expand)