-
-
Notifications
You must be signed in to change notification settings - Fork 1k
added automatic release svg generation #2327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
fixed colors
for more information, see https://pre-commit.ci
sarahboyce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! This is really strong
I have added some suggestions to make it easier to generate future svgs and how to make the generated image a little closer to the existing image
I think once we're happy with the generated image, we might want to consider writing a few tests
Co-authored-by: Sarah Boyce <[email protected]>
Co-authored-by: Sarah Boyce <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Hi , thank you for the review . I have added suggested changes , please do let me know if anything needs to be added |
sarahboyce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have suggested changes which would end up generating the following image
After commiting suggestions you will need to update the current image committed by re-running the command.
A nice to have would be if we can end the graph one line earlier and add a fade out 🤔
We still have some minor discrepancies but I think it's "close enough"
this PR adds feature #2297, fixes #2297
PR introduces following changes:
Automates the generation of the release roadmap SVG using a Python script and json.
changes download page from release-roadmap.png to release-roadmap.svg