Add support for the adjusting temperature for gpt-5 models #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erature setting based on model type to enhance AI response variability
404pilo
reviewed
Oct 4, 2025
| temperature: 0, | ||
| temperature: gpt5_models.includes(this.config.model) ? 1 : 0, | ||
| top_p: 0.1, | ||
| max_tokens: this.config.maxTokensOutput |
There was a problem hiding this comment.
for the gpt-5 model family, the api expects this property to be max_completion_tokens
error: {
message: "Unsupported parameter: 'max_tokens' is not supported with this model. Use 'max_completion_tokens' instead.",
type: 'invalid_request_error',
param: 'max_tokens',
code: 'unsupported_parameter'
},
code: 'unsupported_parameter',
param: 'max_tokens',
type: 'invalid_request_error'
}
│
└ ✖ 400 Unsupported parameter: 'max_tokens' is not supported with this model. Use 'max_completion_tokens' instead.
|
@BB-BenBridges i've added a comment, please also target master branch <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ (openAi.ts): introduce support for new GPT-5 models and adjust temperature setting based on model type to enhance AI response variability