Skip to content

Conversation

@vblagoje
Copy link
Member

@vblagoje vblagoje commented Nov 26, 2025

Why

Updates the default OpenAI model from gpt-4o-mini to gpt-5-mini to use the latest model version by default.

What

  • Changed default model parameter in OpenAIChatGenerator and OpenAIGenerator from gpt-4o-mini to gpt-5-mini
  • Updated docstrings and documentation examples to reflect the new default
  • Updated test expectations to match the new default model
  • Made tests more robust by avoiding hardcoded model names where appropriate

How can it be used

The default model is now gpt-5-mini when initializing OpenAI generators without specifying a model:

# Uses gpt-5-mini by default
generator = OpenAIChatGenerator()

# Still works with explicit model specification
generator = OpenAIChatGenerator(model="gpt-4o")

How did you test it

  • Updated all unit tests to expect gpt-5-mini as the default
  • Made integration tests more flexible to handle model name variations
  • Updated test mocks and fixtures to use the new default
  • Marked two flaky integration tests with retry decorators

Notes for the reviewer

This is a straightforward model update. All tests pass and the change is backward compatible - users can still specify any model explicitly.

@vercel
Copy link

vercel bot commented Nov 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
haystack-docs Ignored Ignored Preview Dec 1, 2025 0:37am

@vblagoje vblagoje added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Nov 26, 2025
@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs and removed ignore-for-release-notes PRs with this flag won't be included in the release notes. labels Nov 26, 2025
@vblagoje vblagoje added ignore-for-release-notes PRs with this flag won't be included in the release notes. and removed type:documentation Improvements on the docs labels Nov 26, 2025
@coveralls
Copy link
Collaborator

coveralls commented Nov 27, 2025

Pull Request Test Coverage Report for Build 19822905143

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.189%

Totals Coverage Status
Change from base Build 19820645949: 0.0%
Covered Lines: 14033
Relevant Lines: 15222

💛 - Coveralls

@vblagoje vblagoje marked this pull request as ready for review December 1, 2025 11:26
@vblagoje vblagoje requested a review from a team as a code owner December 1, 2025 11:26
@vblagoje vblagoje requested review from mpangrazzi and removed request for a team December 1, 2025 11:26
@vblagoje vblagoje removed the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Dec 1, 2025
Copy link
Contributor

@mpangrazzi mpangrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok!

@sjrl
Copy link
Contributor

sjrl commented Dec 1, 2025

@vblagoje it still may be good to label this as a breaking change and in the release notes add an upgrade section. Btw when is the end of life of gpt-4o?

@vblagoje
Copy link
Member Author

vblagoje commented Dec 1, 2025

@vblagoje it still may be good to label this as a breaking change and in the release notes add an upgrade section. Btw when is the end of life of gpt-4o?

ok will do, chat version of it very soon but not the gpt-4o - seems like it will be around still for some time

@mpangrazzi
Copy link
Contributor

@vblagoje FYI there was a (probably) fake tests. Re-running test "fixed" it.

@vblagoje
Copy link
Member Author

vblagoje commented Dec 1, 2025

@sjrl @mpangrazzi I'll integrate this one now and then issue PR for Azure and finally huggingface, lmk if you have some objections

@sjrl
Copy link
Contributor

sjrl commented Dec 1, 2025

@sjrl @mpangrazzi I'll integrate this one now and then issue PR for Azure and finally huggingface, lmk if you have some objections

be careful for the Azure one, it's possible that we may want to leave gpt-4o as default there since Azure prefers users to use the responses api to use gpt-5

@vblagoje
Copy link
Member Author

vblagoje commented Dec 1, 2025

@sjrl @mpangrazzi I'll integrate this one now and then issue PR for Azure and finally huggingface, lmk if you have some objections

be careful for the Azure one, it's possible that we may want to leave gpt-4o as default there since Azure prefers users to use the responses api to use gpt-5

Aha, ok, let's go with 4.1-mini there then?

@vblagoje vblagoje merged commit 3ebe9b2 into main Dec 1, 2025
21 checks passed
@vblagoje vblagoje deleted the update_open_ai branch December 1, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants