-
Notifications
You must be signed in to change notification settings - Fork 1
SRE-3458 build: do not provide complete leap distribution #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Tomasz Gromadzki <[email protected]>
JohnMalmberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not checked if a generic leap15:latest is available for from the opensuse docker repository, and if there is, we need to have the "docker cleanup" jobs make sure it is installed.
|
|
||
| // set BASE_DISTRO if necessary | ||
| if (stage_info['target'] == 'leap15') { | ||
| ret_str += ' --build-arg BASE_DISTRO=registry.opensuse.org/opensuse/leap-dnf:' + stage_info['distro_version'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That set of docker containers was selected because it has DNF pre-installed instead of just Zypper. Brian did that to speed up creating a docker image, and it is pulling from an OpenSUSE managed repository that we mirror instead of dockerhub.
daltonbohning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to break current leap builds after landing this but before landing daos-stack/daos#17152?
JohnMalmberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to see the changes in the other PR first.
No. I have adjusted Dockers configuration on Jenkins docker host to handle both: old and new way. |
Done |
The intention of this PR to enable possibility to provide RELEASE version for leap from CI
see daos-stack/daos#17152