-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: lsTool path management and improve workspace file resolution #8985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: lsTool path management and improve workspace file resolution #8985
Conversation
… of the unresolved one
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Documentation ReviewI've reviewed this PR for documentation updates. No documentation changes are needed because:
The improvements (removing custom path rewriting, fixing workspace file resolution) are implementation details that don't require user documentation updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
Description
Code changes:
lsToolusing the IDE/Platform-provided path resolutionTargeted issues
Here's a few of the issues I've found which should be cleared with this change:
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
The best demo of this fix is to compare the current main with the branch running the same task; you can view the demo I just recorded.
Tests
I actually had to remove some tests because they were testing the removed function; that specific functionality is tested elsewhere both in the codebase and in the supporting vscode/node SDKs.
Summary by cubic
Switch lsTool to the IDE path resolver and fix workspace URI checks to prevent false “directory/file not found” errors. Addresses #8877, #8744, #6220.
Written for commit 9a7d15b. Summary will update automatically on new commits.