Skip to content

Conversation

@andreapizzato
Copy link

@andreapizzato andreapizzato commented Dec 3, 2025

Description

Code changes:

  • removed custom path rewriter for lsTool using the IDE/Platform-provided path resolution
  • fixed an issue where a file could be resolved within the workspace but being reported as non-existent

Targeted issues

Here's a few of the issues I've found which should be cleared with this change:

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screen recording or screenshot

The best demo of this fix is to compare the current main with the branch running the same task; you can view the demo I just recorded.

Tests

I actually had to remove some tests because they were testing the removed function; that specific functionality is tested elsewhere both in the codebase and in the supporting vscode/node SDKs.


Summary by cubic

Switch lsTool to the IDE path resolver and fix workspace URI checks to prevent false “directory/file not found” errors. Addresses #8877, #8744, #6220.

  • Bug Fixes
    • Use IDE-provided path resolution in lsTool; remove custom path rewriter.
    • Verify file existence using the resolved workspace URI, not the raw input.
    • Return a clear error when dirPath is missing.

Written for commit 9a7d15b. Summary will update automatically on new commits.

@andreapizzato andreapizzato requested a review from a team as a code owner December 3, 2025 10:06
@andreapizzato andreapizzato requested review from Patrick-Erichsen and removed request for a team December 3, 2025 10:06
@continue
Copy link
Contributor

continue bot commented Dec 3, 2025

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@andreapizzato
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@continue
Copy link
Contributor

continue bot commented Dec 3, 2025

Documentation Review

I've reviewed this PR for documentation updates. No documentation changes are needed because:

  1. Internal refactoring only - The changes simplify internal path handling without affecting the user-facing API
  2. No API changes - The ls tool still accepts the same parameters (dirPath and recursive)
  3. No existing documentation describes the internal path resolution logic that was changed
  4. The tool definition in core/tools/definitions/ls.ts remains unchanged

The improvements (removing custom path rewriting, fixing workspace file resolution) are implementation details that don't require user documentation updates.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@andreapizzato andreapizzato changed the title Fix lsTool path management and improve workspace file resolution fix: lsTool path management and improve workspace file resolution Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant