-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: use more intuitive envvars to manage OTLP and PostHog telemetry settings #8925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…settings Co-Authored-By: Ross Golder <[email protected]>
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
Documentation UpdatesAdded documentation for the new telemetry environment variables: Changes made:
Both new variables:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sestinj could you do a final stamp on this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uinstinct could you update docs for this as well? I think docs have the old ones
Description
Re-opens #8328
resolves CON-4878
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Switch to clearer env vars to control telemetry: CONTINUE_TELEMETRY_ENABLED for PostHog events and CONTINUE_METRICS_ENABLED for OTLP metrics, with smarter DNS checks and warnings when telemetry is blocked. Addresses Linear CON-4878.
Migration
Bug Fixes
Written for commit 64dbb9a. Summary will update automatically on new commits.