test(config): additional tests for drop-in configuration #557
+318
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add equivalent drop-in configuration tests for toolset_config_test.go that were added to provider_config_test.go in the recent commits: - TestConfigDirPathInContext - TestExtendedConfigMergingAcrossDropIns - TestExtendedConfigFromDropInOnly - TestStandaloneConfigDirWithExtendedConfig - TestConfigDirPathInContextStandalone Signed-off-by: Marc Nuri <[email protected]>
Add CmdSuite with TestConfigDir to test the --config-dir flag behavior: - Standalone config-dir loading - Error when config-dir path is a file - Graceful skip for nonexistent directories - Merging with main config via --config flag - Lexical ordering of multiple drop-in files - CLI flags taking precedence over config-dir values Signed-off-by: Marc Nuri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #524 #548
test(config): add drop-in configuration tests for toolset configs
Add equivalent drop-in configuration tests for toolset_config_test.go
that were added to provider_config_test.go
test(cmd): add --config-dir drop-in configuration tests
Add CmdSuite with TestConfigDir to test the --config-dir flag behavior