fix(kubernetes)!: Provider updated for each watcher callback #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Once this one is merged or the related bug is fixed we should start with the 0.0.55 release which should be stable enough. |
nader-ziada
approved these changes
Dec 2, 2025
| } | ||
|
|
||
| allClusterManagers[name] = nil | ||
| p.managers[name] = nil |
Collaborator
There was a problem hiding this comment.
would these managers have any resources that should be cleaned up
Member
Author
There was a problem hiding this comment.
That's a good question.
We don't provide a kubernetes.Manager.Clean method.
The manager itself has a pointer reference to the global config.StaticConfig and an instance of kubernetes.AccessControlClientset.
The clientset has instances of the discovery client, dynamic client, and kubernetes interface. But AFAICT, none of those clients provide clean up methods.
I might have missed something, but I'd say that there's no clean up needed.
The kubernetes.Provider watch-related functionality is restarted for each watch notification that affects its state. Signed-off-by: Marc Nuri <[email protected]>
manusa
force-pushed
the
fix/provider-watch
branch
from
565c57e to
d3430b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #522
Replaces #531
The
kubernetes.Providerwatch-related functionality is restarted for each watch notification that affects its state.