-
Notifications
You must be signed in to change notification settings - Fork 0
Add configurable host #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for configurable host binding in the web server configuration, allowing users to specify a custom bind URI instead of just a port number.
- Adds
bindconfiguration option to web settings with a nil default - Updates puma.rb to prioritize bind URI over port configuration
- Includes example configuration showing how to use the bind option
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/sagittarius/configuration.rb | Adds bind: nil to the web configuration defaults |
| config/sagittarius.example.yml | Adds example comment for the new bind configuration option |
| config/puma.rb | Updates Puma configuration to use bind URI if specified, otherwise falls back to port |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2200628972 Status: Passed Job summariesrspec: [ee]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12348900707/artifacts/tmp/coverage/index.html rspec: [ce]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12348900705/artifacts/tmp/coverage/index.html rubocop717 files inspected, no offenses detected |
Co-authored-by: Copilot <[email protected]> Signed-off-by: Dario Pranjic <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Dario Pranjic <[email protected]>
No description provided.