Skip to content

Conversation

@Knerio
Copy link
Member

@Knerio Knerio commented Dec 6, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for configurable host binding in the web server configuration, allowing users to specify a custom bind URI instead of just a port number.

  • Adds bind configuration option to web settings with a nil default
  • Updates puma.rb to prioritize bind URI over port configuration
  • Includes example configuration showing how to use the bind option

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
lib/sagittarius/configuration.rb Adds bind: nil to the web configuration defaults
config/sagittarius.example.yml Adds example comment for the new bind configuration option
config/puma.rb Updates Puma configuration to use bind URI if specified, otherwise falls back to port

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2200628972

Status: Passed
Duration: 3 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12348900707/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2200628972/test_report
Finished in 20.79 seconds (files took 10.8 seconds to load)
1279 examples, 0 failures
Line Coverage: 91.29% (4412 / 4833)
[TEST PROF INFO] Time spent in factories: 00:11.668 (43.7% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12348900705/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2200628972/test_report
Finished in 19.79 seconds (files took 11.48 seconds to load)
1232 examples, 0 failures
Line Coverage: 90.72% (4244 / 4678)
[TEST PROF INFO] Time spent in factories: 00:10.760 (41.26% of total time)

rubocop

717 files inspected, no offenses detected

Knerio and others added 2 commits December 7, 2025 14:07
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Dario Pranjic <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Dario Pranjic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants