Skip to content

Conversation

@Knerio
Copy link
Member

@Knerio Knerio commented Nov 30, 2025

close #163

@Knerio Knerio self-assigned this Nov 30, 2025
@Knerio Knerio marked this pull request as ready for review November 30, 2025 00:51
Copilot finished reviewing on behalf of Knerio November 30, 2025 00:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Docker build cache support to improve build performance by storing and retrieving build cache layers from a container registry.

  • Adds --cache-from flag to read cache from the registry during builds
  • Adds --cache-to flag to write build cache to the registry for single-image builds

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
support/helpers.sh Adds --cache-from flag to the build_image function to pull cache from registry
.gitlab/ci/container-build.gitlab-ci.yml Adds --cache-to flag to .single-image-build-base to push cache to registry
Comments suppressed due to low confidence (1)

.gitlab/ci/container-build.gitlab-ci.yml:48

  • The .variant-image-build-base template is missing the --cache-to flag that was added to .single-image-build-base. This creates inconsistency in caching behavior - variant builds won't write to the cache registry, potentially limiting cache effectiveness for these builds. Consider adding --cache-to type=registry,ref=ghcr.io/code0-tech/reticulum/ci-cache to line 48 to match the caching strategy in .single-image-build-base.
      build_image 
      $image
      $CI_PIPELINE_ID 
      "--build-arg VARIANT=$VARIANT --output type=registry,push-by-digest=true --metadata-file manifest-${CI_JOB_ID}.json"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 30, 2025

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/reticulum/-/pipelines/2187591510

Status: Passed
Duration: 6 minutes

@Taucher2003 Taucher2003 merged commit b91dd96 into main Nov 30, 2025
1 check passed
@Taucher2003 Taucher2003 deleted the 163-setup-build-cache branch November 30, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup build cache

3 participants