Skip to content

pr-writer-impl lower level impl for js object printing, removes several dependencies #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 9, 2025
Merged

pr-writer-impl lower level impl for js object printing, removes several dependencies #256

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
997da9e
* remove pr-writer-impl dependence on lazy seq
swannodette Jun 9, 2025
2982a12
* fix map arg order
swannodette Jun 9, 2025
1887fa4
* revert spurious change
swannodette Jun 9, 2025
865f499
* lower level primitives for map printing
swannodette Jun 9, 2025
71a0002
* fix regex
swannodette Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/main/cljs/cljs/core.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10529,9 +10529,15 @@ reduces them without incurring seq initialization"
(do
(-write writer "#js ")
(print-map
(map (fn [k]
(MapEntry. (cond-> k (some? (re-matches #"[A-Za-z_\*\+\?!\-'][\w\*\+\?!\-']*" k)) keyword) (unchecked-get obj k) nil))
(js-keys obj))
(.map
(js-keys obj)
(fn [k]
(reify
IMapEntry
(-key [_]
(cond-> k (some? (.match k #"^[A-Za-z_\*\+\?!\-'][\w\*\+\?!\-']*$")) keyword))
(-val [_]
(unchecked-get obj k)))))
pr-writer writer opts))

(array? obj)
Expand Down
Loading