Fix a Cannot open <nil> as a Reader

Closes #149

Author: vemv

CHANGELOG.md

@@ -4,7 +4,8 @@
 
 ### Bugs fixed
 
-* Fix a NullPointerException in `orchard.cljs.analysis`. 
+* Fix a NullPointerException in `orchard.cljs.analysis`.
+* Fix a `Cannot open <nil> as a Reader`.
 
 ## 0.9.0 (2022-01-10)
 

src/orchard/namespace.clj

@@ -103,18 +103,22 @@
 ;; These methods search sources on the classpath. Non-classpath source
 ;; files, documentation code, etc within the project directory are ignored.
 
+(defn jvm-clojure-resource-name->ns-name
+  "Given a .clj or .clj `resource-name`, returns its namespace name."
+  [resource-name]
+  (when (misc/clj-file? resource-name)
+    (some-> resource-name
+            io/resource ;; can return nil for Emacs backup files, for example
+            read-namespace)))
+
 (defn classpath-namespaces
   "Returns all namespaces defined in sources on the classpath or the specified
   classpath URLs."
   ([classpath-urls]
    (->> classpath-urls
         (pmap cp/classpath-seq)
         (apply concat)
-        (pmap (fn [x]
-                (when (misc/clj-file? x)
-                  x)))
-        (filter identity)
-        (pmap (comp read-namespace io/resource))
+        (pmap jvm-clojure-resource-name->ns-name)
         (filter identity)
         (sort)))
   ([]

test/orchard/namespace_test.clj

@@ -2,7 +2,7 @@
   (:require
    [clojure.java.io :as io]
    [clojure.string :as str]
-   [clojure.test :refer [deftest is testing]]
+   [clojure.test :refer [are deftest is testing]]
    [orchard.misc :as misc]
    [orchard.namespace :as sut]))
 
@@ -86,3 +86,9 @@
         (is (= nses (map (comp sut/read-namespace    ; src -> ns
                                sut/canonical-source) ; ns -> src
                          nses)))))))
+
+(deftest jvm-clojure-resource-name->ns-name
+  (are [input expected] (= expected
+                           (sut/jvm-clojure-resource-name->ns-name input))
+    "orchard/namespace_test.clj"   'orchard.namespace-test
+    "orchard/namespace_teeest.clj" nil))