Skip to content

Callback with Flickr API error message and code instead of "stat != ok" #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Callback with Flickr API error message and code instead of "stat != ok" #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'; /*jslint es5: true, node: true, indent: 2 */
var oauth = require('oauth');
var streaming = require('streaming');
var logger = require('loge');
//var logger = require('loge');

var request = require('./lib/request');
var response = require('./lib/response');
Expand All @@ -11,7 +11,7 @@ var response = require('./lib/response');
var oauth_endpoints = {
request: 'http://www.flickr.com/services/oauth/request_token',
authorize: 'http://www.flickr.com/services/oauth/authorize',
access: 'http://www.flickr.com/services/oauth/access_token',
access: 'http://www.flickr.com/services/oauth/access_token'
};

var requestFactory = function(consumer_key, consumer_secret, oauth_token, oauth_token_secret) {
Expand Down Expand Up @@ -39,7 +39,9 @@ var requestFactory = function(consumer_key, consumer_secret, oauth_token, oauth_
if (err) return callback(err);

if (result.stat !== 'ok') {
return callback(new Error('stat != ok in Flickr API response'), result);
var message = result.message ? result.message : (result.err ? result.err.msg : 'Unknown Flickr API Error (stat != ok))'),
code = result.code ? result.code : (result.err ? result.err.code : 0);
return callback(new Error('[ERR-'+code + '] : ' + message));
}

callback(null, result);
Expand Down