allow extra members for converted structs

[grisumbras]

Fix #991

[cppalliance-bot]

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

[cppalliance-bot]

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

[cppalliance-bot]

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

[cppalliance-bot]

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

[cppalliance-bot]

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (6071cd5) to head (7b16bf7).
Report is 5 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1056      +/-   ##
===========================================
+ Coverage    93.40%   93.69%   +0.29%     
===========================================
  Files           91       91              
  Lines         8658     9138     +480     
===========================================
+ Hits          8087     8562     +475     
- Misses         571      576       +5     

Files with missing lines	Coverage Δ
include/boost/json/detail/parse_into.hpp	100.00% <100.00%> (+0.25%)	⬆️
include/boost/json/detail/value_to.hpp	100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6071cd5...7b16bf7. Read the comment docs.

[cppalliance-bot]

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

[cppalliance-bot]

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

[cppalliance-bot]

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

[cppalliance-bot]

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

[cppalliance-bot]

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

[cppalliance-bot]

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

[cppalliance-bot]

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

[cppalliance-bot]

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

[cppalliance-bot]

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

[cppalliance-bot]

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

[cppalliance-bot]

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

[cppalliance-bot]

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

[cppalliance-bot]

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

[freitass]

@grisumbras I believe there's a bug in this code. Consider the following scenario:

struct X
{
    int a;
    float b;
    std::string c;
};

BOOST_DESCRIBE_STRUCT(X, (), (a, b, c))

struct W
{
    X x;
};

BOOST_DESCRIBE_STRUCT(W, (), (x))

// ...

const auto json = R"(
{
    "x": {
        "unknown": [],
        "a": 1,
        "b": 3.14,
        "c": "hello"
    }
})";

W w{};
std::error_code ec;
parse_into(w, json, ec);

BOOST_TEST( !ec );               // Ok.
BOOST_TEST( w.x.a == 1 );        // Error: w.x.a is 0
BOOST_TEST( w.x.b == 3.14f );     // Error: w.x.b is 0.0
BOOST_TEST( w.x.c == "hello" );  // Error: w.x.c is ""

Changing this line to signal_value seems to fix the issue:

Suggested change

	return parent_->signal_end(ec);
	return parent_->signal_value(ec);

Please confirm if that was intentional as I might be missing some other scenario. Thanks!

[freitass]

#1129