Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@petty
Copy link

@petty petty commented Oct 4, 2016

this allows for the "right-click" contextual menu to show shortcuts for viewing the current file

[Short description of suggestion]

Steps which explain the enhancement

  1. view any file (that is on github)
  2. select the file, a line, or lines like you normally would with "Open On Github"
  3. Leave your cursor right where it is & right click with your mouse or trackpad

Current and suggested behavior

this adds easier & maybe faster access to Open On Github functionality

Why would the enhancement be useful to most users

This adds another way to access existing functionality

Atom Version: 1.10.2
OS and Version: OS X 10.11.6

this allows for the "right-click" contextual menu to show shortcuts for viewing the current
Copy link

@danielbayley danielbayley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better with more specific targets? The context menu gets really cluttered as it is, and underutilised as a consequence. When I add any context menu items to any of my packages I try and make sure they only show up where relevant.

Something like:

'context-menu':
  '.tree-view .project-root-header,
   .status-bar .git-branch': [
      { label: 'Open On Github', command: 'open-on-github:repository' }
   ]
  '.tree-view .file': [
      { label: 'Open On Github', command: 'open-on-github:file' }
  ]

for example.

@winstliu
Copy link
Contributor

winstliu commented Nov 2, 2017

@danielbayley That wouldn't work since Open on GitHub looks at the active pane item to determine which repo is open. Having the commands on the Tree View would mean that the Tree View would be the active pane item and so nothing would happen.

@UziTech
Copy link
Contributor

UziTech commented Aug 20, 2019

@50Wliu this would work once #111 is merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants