Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@nightuser
Copy link
Contributor

Initial implementation of multilingual spellchecking. Doesn't work on OS X yet, as I don't have any Macs right now.

@zcbenz
Copy link
Contributor

zcbenz commented Jun 1, 2016

👍

@zcbenz zcbenz merged commit f9e8503 into atom:master Jun 1, 2016
@zcbenz
Copy link
Contributor

zcbenz commented Jun 1, 2016

Sorry I just realized there is another huge PR #50 waiting there, I'm reseting the master branch and will revisit this PR later.

@anaisbetts
Copy link
Contributor

I think that my PR breaks the concept of this one - @nightuser, what are you using multiple dictionary support for? Maybe I'm missing a scenario here

@nightuser
Copy link
Contributor Author

nightuser commented Jun 1, 2016

@paulcbetts Well, I'm writing my thesis in Sublime because of similar multilingual support. It's mainly written in Russian, but has many English terms.

I don't think that it'd be hard to implement that in your version, as I've borrowed the idea from Chromium (it's supporting multilingual spellcheck since August). I'll look into your PR soon.

@nightuser
Copy link
Contributor Author

@paulcbetts I've forgot to mention you in the original version of the post above. And I don't know whether notification has been sent to you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants