Skip to content

Add Java 25 build compatibility for TinkerPop 3.8 #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.8-dev
Choose a base branch
from
+43 −4
Open

Add Java 25 build compatibility for TinkerPop 3.8 #3283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8734ac
Add Java 25 build compatibility via Groovy 4.0.30-SNAPSHOT
jrepp Nov 30, 2025
184c7ef
Fix Java 25 test compatibility issues
jrepp Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../tinkerpop/gremlin/process/traversal/strategy/verification/LambdaRestrictionStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ private LambdaRestrictionStrategy() {
@Override
public void apply(final Traversal.Admin<?, ?> traversal) {
for (final Step<?, ?> step : traversal.getSteps()) {
if ((step instanceof LambdaHolder || step instanceof ComparatorHolder) && step.toString().contains("lambda"))
if ((step instanceof LambdaHolder || step instanceof ComparatorHolder) && step.toString().toLowerCase().contains("lambda"))
throw new VerificationException("The provided traversal contains a lambda step: " + step, traversal);
}
}
Expand Down
11 changes: 9 additions & 2 deletions gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/jsr223/ImportGremlinPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,15 @@ public void shouldImportWildcardFields() throws Exception {
.fieldsImports(Collections.singletonList(Math.class.getCanonicalName() + "#*")).create();

final DefaultImportCustomizer customizer = (DefaultImportCustomizer) module.getCustomizers().get()[0];
assertThat(customizer.getFieldImports(), is(new HashSet<>(
Arrays.asList(Math.class.getField("PI"), Math.class.getField("E")))));
// Math.TAU was added in Java 19
final HashSet<Field> expectedFields = new HashSet<>(Arrays.asList(
Math.class.getField("PI"), Math.class.getField("E")));
try {
expectedFields.add(Math.class.getField("TAU"));
} catch (NoSuchFieldException ignored) {
// TAU not available in Java < 19
}
assertThat(customizer.getFieldImports(), is(expectedFields));
}

@Test
Expand Down
32 changes: 32 additions & 0 deletions gremlin-groovy/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,38 @@ limitations under the License.
<compilerArgs>
<arg>-parameters</arg>
</compilerArgs>
<annotationProcessorPaths>
<path>
<groupId>org.apache.tinkerpop</groupId>
<artifactId>gremlin-annotations</artifactId>
<version>${project.version}</version>
</path>
<path>
<groupId>org.apache.tinkerpop</groupId>
<artifactId>gremlin-core</artifactId>
<version>${project.version}</version>
</path>
<path>
<groupId>org.apache.tinkerpop</groupId>
<artifactId>gremlin-shaded</artifactId>
<version>${project.version}</version>
</path>
<path>
<groupId>org.apache.tinkerpop</groupId>
<artifactId>gremlin-language</artifactId>
<version>${project.version}</version>
</path>
<path>
<groupId>com.squareup</groupId>
<artifactId>javapoet</artifactId>
<version>${javapoet.version}</version>
</path>
<path>
<groupId>org.antlr</groupId>
<artifactId>antlr4-runtime</artifactId>
<version>${antlr4.version}</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ limitations under the License.
<commons.text.version>1.10.0</commons.text.version>
<cucumber.version>7.21.1</cucumber.version>
<exp4j.version>0.4.8</exp4j.version>
<groovy.version>4.0.25</groovy.version>
<groovy.version>4.0.30-SNAPSHOT</groovy.version>
Copy link
Contributor

@Cole-Greer Cole-Greer Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be upgraded to a SNAPSHOT version in order to work? I would like to stick to fully released versions.

Copy link
Contributor

@Cole-Greer Cole-Greer Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I saw the reference to this in the PR description. I believe this PR will unfortunately remain blocked until groovy merges and releases their fix.

<guice.version>4.2.3</guice.version>
<hadoop.version>3.3.3</hadoop.version>
<hamcrest.version>3.0</hamcrest.version>
Expand Down