Skip to content

build: add import maps extract_api_to_json #32407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: add import maps extract_api_to_json #32407

wants to merge 1 commit into from
+60 −22

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Nov 26, 2025

In order to get the correct types for the aria entries in the API json, we need to map external packages.

fixes #angular/angular#65566

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Nov 26, 2025
@JeanMeche JeanMeche requested a review from devversion November 26, 2025 01:33
josephperrott
josephperrott reviewed Dec 1, 2025
View reviewed changes
@JeanMeche JeanMeche marked this pull request as ready for review December 1, 2025 17:08
@JeanMeche JeanMeche requested a review from a team as a code owner December 1, 2025 17:08
@JeanMeche JeanMeche requested review from adolgachev and andrewseguin and removed request for a team December 1, 2025 17:08
josephperrott
josephperrott reviewed Dec 1, 2025
View reviewed changes
@JeanMeche
build: add import maps extract_api_to_json
7858857 
In order to get the correct types for the aria entries in the API json, we need to map external packages.

fixes #angular/angular#65566
josephperrott
josephperrott approved these changes Dec 2, 2025
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devversion
devversion approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@devversion devversion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is likely a more flexible approache to this, but this seems low-risk and sufficient for now. LGTM

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JeanMeche @devversion @josephperrott