refactor(cdk/scrolling): refactors CdkVirtualScrollViewport destroyed… #32357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkyZeroZx
requested review from
andrewseguin and
tjshiu
and removed request for
a team
… flag Refactors the viewport destruction logic to use the `DestroyRef` service, removing the need for a custom `_isDestroyed` flag.
SkyZeroZx
force-pushed
the
refactor/destroyRef-use-destroyed
branch
from
4fbc997 to
1d6b39b
Compare
tjshiu
reviewed
Dec 2, 2025
| private _injector = inject(Injector); | ||
|
|
||
| private _isDestroyed = false; | ||
| private _destroyRef = inject(DestroyRef); |
Contributor
There was a problem hiding this comment.
Should this be private readonly?
Contributor
Author
There was a problem hiding this comment.
I was following the convention of the other injected properties; theoretically, no one should overwrite them, considering it implicit. Should we still use readonly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… flag
Refactors the viewport destruction logic to use the
DestroyRefservice, removing the need for a custom_isDestroyedflag.