Skip to content

fix(@angular/cli): ensure dependencies are resolved correctly for node modules directory check #31861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −9
Open

fix(@angular/cli): ensure dependencies are resolved correctly for node modules directory check #31861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions packages/angular/cli/src/command-builder/architect-base-command-module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ import {
WorkspaceNodeModulesArchitectHost,
} from '@angular-devkit/architect/node';
import { json } from '@angular-devkit/core';
import { existsSync } from 'node:fs';
import { resolve } from 'node:path';
import { createRequire } from 'node:module';
import { isPackageNameSafeForAnalytics } from '../analytics/analytics';
import { EventCustomDimension, EventCustomMetric } from '../analytics/analytics-parameters';
import { assertIsError } from '../utilities/error';
Expand Down Expand Up @@ -210,15 +209,13 @@ export abstract class ArchitectBaseCommandModule<T extends object>
return;
}

// Check if yarn PnP is used. https://yarnpkg.com/advanced/pnpapi#processversionspnp
if (process.versions.pnp) {
return;
}
const workspaceResolve = createRequire(basePath + '/').resolve;

try {
workspaceResolve('@angular/core');

// Check for a `node_modules` directory (npm, yarn non-PnP, etc.)
if (existsSync(resolve(basePath, 'node_modules'))) {
return;
}
} catch {}

this.context.logger.warn(
`Node packages may not be installed. Try installing with '${this.context.packageManager.name} install'.`,
Expand Down