Tooltip design fixes (#1515)

* modify default distance between tooltip and button

* adjusting tooltip margin so large scale tip distance is 5px

* removing accidental comment

* updating comment for tooltip offset

Co-authored-by: Danni <[email protected]>

Author: LFDanLu

packages/@adobe/spectrum-css-temp/components/tooltip/index.css

@@ -14,7 +14,7 @@ governing permissions and limitations under the License.
 @import '../overlay/index.css';
 
 :root {
-  --spectrum-tooltip-target-offset: 3px;
+  --spectrum-tooltip-target-offset: var(--spectrum-global-dimension-size-40);
   /* This variable needs to be updated in Spectrum DNA. Using the height variable so it scales to spectrum-large */
   --spectrum-tooltip-tip-width: var(--spectrum-tooltip-tip-height);
 }

packages/@react-spectrum/tooltip/src/TooltipTrigger.tsx

@@ -19,7 +19,7 @@ import {useOverlayPosition} from '@react-aria/overlays';
 import {useTooltipTrigger} from '@react-aria/tooltip';
 import {useTooltipTriggerState} from '@react-stately/tooltip';
 
-const DEFAULT_OFFSET = 7; // Closest visual match to Spectrum's mocks
+const DEFAULT_OFFSET = -1; // Offset needed to reach 4px/5px (med/large) distance between tooltip and trigger button
 const DEFAULT_CROSS_OFFSET = 0;
 
 function TooltipTrigger(props: SpectrumTooltipTriggerProps) {