Rename internal setting IMPLEMENTED_FUNCTIONS -> WASM_EXPORTS. NFC (emscripten-core#13917)

As of emscripten-core#13873 this settings not also included exported globals
so the name stopped making as much sense.

Author: sbc100

emscripten.py

@@ -117,7 +117,7 @@ def update_settings_glue(metadata, DEBUG):
   settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE += metadata['globalImports']
 
   all_exports = metadata['exports'] + list(metadata['namedGlobals'].keys())
-  settings.IMPLEMENTED_FUNCTIONS = [asmjs_mangle(x) for x in all_exports]
+  settings.WASM_EXPORTS = [asmjs_mangle(x) for x in all_exports]
 
   settings.BINARYEN_FEATURES = metadata['features']
   if settings.RELOCATABLE:
@@ -127,7 +127,7 @@ def update_settings_glue(metadata, DEBUG):
     if settings.INITIAL_TABLE == -1:
       settings.INITIAL_TABLE = metadata['tableSize'] + 1
 
-  settings.HAS_MAIN = settings.MAIN_MODULE or settings.STANDALONE_WASM or '_main' in settings.IMPLEMENTED_FUNCTIONS
+  settings.HAS_MAIN = settings.MAIN_MODULE or settings.STANDALONE_WASM or '_main' in settings.WASM_EXPORTS
 
   # When using dynamic linking the main function might be in a side module.
   # To be safe assume they do take input parametes.
@@ -187,7 +187,7 @@ def set_memory(static_bump):
 def report_missing_symbols(pre):
   # the initial list of missing functions are that the user explicitly exported
   # but were not implemented in compiled code
-  missing = set(settings.USER_EXPORTED_FUNCTIONS) - set(settings.IMPLEMENTED_FUNCTIONS)
+  missing = set(settings.USER_EXPORTED_FUNCTIONS) - set(settings.WASM_EXPORTS)
 
   for requested in sorted(missing):
     if (f'function {requested}(') not in pre:
@@ -205,7 +205,7 @@ def report_missing_symbols(pre):
     # maximum compatibility.
     return
 
-  if settings.EXPECT_MAIN and '_main' not in settings.IMPLEMENTED_FUNCTIONS:
+  if settings.EXPECT_MAIN and '_main' not in settings.WASM_EXPORTS:
     # For compatibility with the output of wasm-ld we use the same wording here in our
     # error message as if wasm-ld had failed (i.e. in LLD_REPORT_UNDEFINED mode).
     exit_with_error('entry symbol not defined (pass --no-entry to suppress): main')

src/compiler.js

@@ -66,7 +66,7 @@ if (settingsFile) {
 
 EXPORTED_FUNCTIONS = set(EXPORTED_FUNCTIONS);
 EXCEPTION_CATCHING_ALLOWED = set(EXCEPTION_CATCHING_ALLOWED);
-IMPLEMENTED_FUNCTIONS = set(IMPLEMENTED_FUNCTIONS);
+WASM_EXPORTS = set(WASM_EXPORTS);
 INCOMING_MODULE_JS_API = set(INCOMING_MODULE_JS_API);
 
 RUNTIME_DEBUG = LIBRARY_DEBUG || GL_DEBUG;

src/jsifier.js

@@ -134,7 +134,7 @@ function JSify(functionsOnly) {
       }
 
       // if the function was implemented in compiled code, we just need to export it so we can reach it from JS
-      if (finalName in IMPLEMENTED_FUNCTIONS) {
+      if (finalName in WASM_EXPORTS) {
         EXPORTED_FUNCTIONS[finalName] = 1;
         // stop here: we don't need to add anything from our js libraries, not even deps, compiled code is on it
         return '';
@@ -147,7 +147,7 @@ function JSify(functionsOnly) {
       var noExport = false;
 
       if (!LibraryManager.library.hasOwnProperty(ident)) {
-        if (!(finalName in IMPLEMENTED_FUNCTIONS) && !LINKABLE) {
+        if (!(finalName in WASM_EXPORTS) && !LINKABLE) {
           var msg = 'undefined symbol: ' + ident;
           if (dependent) msg += ' (referenced by ' + dependent + ')';
           if (ERROR_ON_UNDEFINED_SYMBOLS) {

src/parseTools.js

@@ -1301,7 +1301,7 @@ function addReadyPromiseAssertions(promise) {
 }
 
 function makeMalloc(source, param) {
-  if ('_malloc' in IMPLEMENTED_FUNCTIONS) {
+  if ('_malloc' in WASM_EXPORTS) {
     return `_malloc(${param})`;
   }
   // It should be impossible to call some functions without malloc being

src/postamble_minimal.js

@@ -76,7 +76,7 @@ function initRuntime(asm) {
 #endif
 #endif
 
-#if '___wasm_call_ctors' in IMPLEMENTED_FUNCTIONS
+#if '___wasm_call_ctors' in WASM_EXPORTS
   asm['__wasm_call_ctors']();
 #endif
 

src/preamble.js

@@ -184,12 +184,12 @@ function cwrap(ident, returnType, argTypes, opts) {
 #if ASSERTIONS
 // We used to include malloc/free by default in the past. Show a helpful error in
 // builds with assertions.
-#if !('_malloc' in IMPLEMENTED_FUNCTIONS)
+#if !('_malloc' in WASM_EXPORTS)
 function _malloc() {
   abort("malloc() called but not included in the build - add '_malloc' to EXPORTED_FUNCTIONS");
 }
 #endif // malloc
-#if !('_free' in IMPLEMENTED_FUNCTIONS)
+#if !('_free' in WASM_EXPORTS)
 function _free() {
   // Show a helpful error since we used to include free by default in the past.
   abort("free() called but not included in the build - add '_free' to EXPORTED_FUNCTIONS");
@@ -972,7 +972,7 @@ function createWasm() {
 #endif
 #endif
 
-#if '___wasm_call_ctors' in IMPLEMENTED_FUNCTIONS
+#if '___wasm_call_ctors' in WASM_EXPORTS
     addOnInit(Module['asm']['__wasm_call_ctors']);
 #endif
 

src/settings_internal.js

@@ -62,8 +62,8 @@ var EMBIND = 0;
 // Whether the main() function reads the argc/argv parameters.
 var MAIN_READS_PARAMS = 1;
 
-// List of functions implemented in compiled code; received from the backend.
-var IMPLEMENTED_FUNCTIONS = [];
+// List of symbols exported from compiled code
+var WASM_EXPORTS = [];
 
 // Name of the file containing the Fetch *.fetch.js, if relevant
 var FETCH_WORKER_FILE = '';