Skip to content

Conversation

@windxu88
Copy link
Collaborator

Description

Explicitly set UTR to 1.42.0 for iOS jobs to fix signing issue.

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity:
  • Halo Effect:

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Nov 18, 2025

PR Reviewer Guide 🔍

(Review updated until commit ea9661a)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

The code changes are small and localized, but they affect CI job generation logic which requires careful validation of undocumented side-effects.
🏅 Score: 75

The PR correctly implements the version pinning for UTR on iOS, but it also includes undocumented changes to CI job filtering that should have been explained in the description.
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Undocumented Change

Tests for Unity version 2021.3 were previously skipped for mobile platforms but are now being included. Please confirm if this is intentional and update the PR description.

foreach (var version in supportedVersions)
{
CI Logic Change

The filtering logic for mobile tests has been changed to exclude all TvOS jobs. Previously, TvOS jobs for Unity 2021.3 were included. Please verify this is the intended behavior.

IEnumerable<Dependency> allMobileFunctionalTests = new MobileFunctionalTests().AsDependencies().Where( d => !d.JobId.Contains("TvOS"));
// Run functional build jobs on TvOS for all Unity versions.
IEnumerable<Dependency> allTvOSFunctionalBuildJobs = new MobileFunctionalBuildJobs().AsDependencies().Where(d=> d.JobId.Contains("TvOS"));

IEnumerable<Dependency> allEditorPerformanceTests = new EditorPerformanceTests().AsDependencies();
IEnumerable<Dependency> allStandalonePerformanceTests = new StandalonePerformanceTests().AsDependencies();
IEnumerable<Dependency> allStandaloneIl2CppPerformanceTests = new StandaloneIl2CppPerformanceTests().AsDependencies();
// Run performance tests in all Unity versions on all mobile platforms except TvOS.
IEnumerable<Dependency> allMobilePerformanceTests = new MobilePerformanceTests().AsDependencies().Where( d => !d.JobId.Contains("TvOS"));
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@windxu88 windxu88 requested a review from K-Tone November 18, 2025 22:20
@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Nov 18, 2025

Persistent review updated to latest commit ea9661a

@codecov-git.colasdn.top
Copy link

codecov-git.colasdn.top bot commented Nov 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2286      +/-   ##
===========================================
+ Coverage    76.81%   76.83%   +0.02%     
===========================================
  Files          476      476              
  Lines        88726    88831     +105     
===========================================
+ Hits         68155    68257     +102     
- Misses       20571    20574       +3     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.53% <ø> (+0.13%) ⬆️
inputsystem_MacOS_2022.3_project 75.40% <ø> (+0.70%) ⬆️
inputsystem_MacOS_6000.0 5.31% <ø> (+0.13%) ⬆️
inputsystem_MacOS_6000.0_project 77.32% <ø> (+0.72%) ⬆️
inputsystem_MacOS_6000.2 5.31% <ø> (+0.13%) ⬆️
inputsystem_MacOS_6000.2_project 77.32% <ø> (+0.72%) ⬆️
inputsystem_MacOS_6000.3 5.31% <ø> (+0.13%) ⬆️
inputsystem_MacOS_6000.3_project 77.32% <ø> (+0.72%) ⬆️
inputsystem_MacOS_6000.4 5.32% <ø> (+0.13%) ⬆️
inputsystem_MacOS_6000.4_project 77.33% <ø> (+0.72%) ⬆️
inputsystem_MacOS_6000.5 5.32% <ø> (+0.13%) ⬆️
inputsystem_MacOS_6000.5_project 77.33% <ø> (+0.72%) ⬆️
inputsystem_Ubuntu_2022.3 5.53% <ø> (+0.13%) ⬆️
inputsystem_Ubuntu_2022.3_project 75.20% <ø> (+0.70%) ⬆️
inputsystem_Ubuntu_6000.0 5.31% <ø> (+0.13%) ⬆️
inputsystem_Ubuntu_6000.0_project 77.13% <ø> (+0.72%) ⬆️
inputsystem_Ubuntu_6000.2 5.31% <ø> (+0.13%) ⬆️
inputsystem_Ubuntu_6000.2_project 77.13% <ø> (+0.72%) ⬆️
inputsystem_Ubuntu_6000.3 5.32% <ø> (+0.13%) ⬆️
inputsystem_Ubuntu_6000.3_project 77.12% <ø> (+0.71%) ⬆️
inputsystem_Ubuntu_6000.4 5.32% <ø> (+0.13%) ⬆️
inputsystem_Ubuntu_6000.4_project 77.14% <ø> (+0.72%) ⬆️
inputsystem_Ubuntu_6000.5 5.32% <ø> (+0.13%) ⬆️
inputsystem_Ubuntu_6000.5_project 77.14% <ø> (+0.73%) ⬆️
inputsystem_Windows_2022.3 5.53% <ø> (+0.13%) ⬆️
inputsystem_Windows_2022.3_project 75.53% <ø> (+0.71%) ⬆️
inputsystem_Windows_6000.0 5.31% <ø> (+0.13%) ⬆️
inputsystem_Windows_6000.0_project 77.45% <ø> (+0.72%) ⬆️
inputsystem_Windows_6000.2 5.31% <ø> (+0.13%) ⬆️
inputsystem_Windows_6000.2_project 77.45% <ø> (+0.73%) ⬆️
inputsystem_Windows_6000.3 5.31% <ø> (+0.13%) ⬆️
inputsystem_Windows_6000.3_project 77.45% <ø> (+0.72%) ⬆️
inputsystem_Windows_6000.4 5.32% <ø> (+0.13%) ⬆️
inputsystem_Windows_6000.4_project 77.45% <ø> (+0.72%) ⬆️
inputsystem_Windows_6000.5 5.32% <ø> (+0.13%) ⬆️
inputsystem_Windows_6000.5_project 77.45% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@K-Tone K-Tone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, it will allow merging stuff without overrides again

@K-Tone
Copy link
Collaborator

K-Tone commented Nov 19, 2025

There are some failed runners on this PR, I'll see if rerunning helps that

@windxu88
Copy link
Collaborator Author

  • [Yamato] InputSystem-MobileFunctionalBuildJobs - 6000.0 - Android - mono

Oops, it seems I made a mistake to Android build jobs, will fix it.

@windxu88 windxu88 merged commit 00fd3bf into develop Nov 19, 2025
127 checks passed
@windxu88 windxu88 deleted the disable_trunk_ios branch November 19, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants