-
Notifications
You must be signed in to change notification settings - Fork 330
CHANGE: Use UTR 1.42.0 for iOS jobs #2286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍(Review updated until commit ea9661a)Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
|
Persistent review updated to latest commit ea9661a |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2286 +/- ##
===========================================
+ Coverage 76.81% 76.83% +0.02%
===========================================
Files 476 476
Lines 88726 88831 +105
===========================================
+ Hits 68155 68257 +102
- Misses 20571 20574 +3 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
K-Tone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change, it will allow merging stuff without overrides again
|
There are some failed runners on this PR, I'll see if rerunning helps that |
Oops, it seems I made a mistake to Android build jobs, will fix it. |
Description
Explicitly set UTR to
1.42.0for iOS jobs to fix signing issue.Testing status & QA
Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.