-
Notifications
You must be signed in to change notification settings - Fork 330
NEW: Adding a new documentation page referencing InputSystem videos #2284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: Adding a new documentation page referencing InputSystem videos #2284
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2284 +/- ##
===========================================
- Coverage 76.81% 76.78% -0.03%
===========================================
Files 476 476
Lines 88726 88772 +46
===========================================
+ Hits 68155 68168 +13
- Misses 20571 20604 +33
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change, but an actual technical writer has to see it.
Yes, added @unitALG to review it |
unitALG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments about Videos.md.
About the questions re:internal Google drive, I didn't see any, so I assume these were all uploaded to YouTube? YouTube links are fine, as long as you indicate that the link opens in YouTube, as I indicated.
Correct, they are available in YouTube. |
unitALG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Description
Adding a new documentation page referencing InputSystem videos.
JIRA: https://jira.unity3d.com/browse/ISX-2281
Testing status & QA
N/A
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.