Skip to content

Feat: Points: Add more exclamations #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat: Points: Add more exclamations #650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions botCommands/points.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ function exclamation(points, isGoodQuestion) {
if (points === 4000) {
return '`//TODO: Implement Club 4000`';
}
if (points === 5000) {
return 'FIVE THOUSAND POINTS. Now go touch grass.';
Copy link
Contributor Author

@Asartea Asartea Feb 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return 'FIVE THOUSAND POINTS. Now go touch grass.';
return 'FIVE THOUSAND POINTS, [HALF WAY THERE](https://youtu.be/lDK9QqIzhwk?t=93)'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit and also prevent the youtube embed from popping up? Or intentional?

Suggested change
return 'FIVE THOUSAND POINTS. Now go touch grass.';
return 'FIVE THOUSAND POINTS, [WE'RE HALF WAY THERE!](<https://youtu.be/lDK9QqIzhwk?t=93>)'

Copy link
Contributor Author

@Asartea Asartea Feb 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot all about the Youtube embed. Your version is better; I left out the "WE'RE", because its addressed to a singular person, but looking at it again I think I like it better with the WE'RE included

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That being said, why halfway there for 5k? Considering you may change 10k to quarter of the way there (makes sense for 40k)

If Bon Jovi should be anywhere, I'd say it needs to be 20 (and only 20)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That being said, why halfway there for 5k? Considering you may change 10k to quarter of the way there (makes sense for 40k)

Because 10K is also a nice milestone, and tbh I'm counting on people forgetting what the 5K text was by the time they hit 10K

If Bon Jovi should be anywhere, I'd say it needs to be 20 (and only 20)

I thought about it, but I feel like that might enforce a feeling of 40 points as like a goal to reach (with the associated club-40), rather than something that should just happen as a result of making good contributions to the Discord.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair on the point about 20. 5k being "halfway" (given the 10k message) still feels a little odd to me, though that's only my opinion and not blocking of course.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair on the point about 20. 5k being "halfway" (given the 10k message) still feels a little odd to me, though that's only my opinion and not blocking of course.

I get that, and I partially agree, but what I'm basically hoping for is that at some point A someone will get to 5K, go huh that's true, another 5K and I'm up to the next order of the magnitude, then at some point B will get to 10K, go huh that's a fun club-40 joke, and that point A and B will be far enough apart nobody will notice the discrepancy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Asartea, I think you are getting warmer. These messages are definitely more celebratory in tone.

But I think for anyone earning 5k+ points, represents a sincere and long-term commitment on the part of the receiver to helping innumerable learners on their journey, and I'd think that the messages beyond even 1k (I know this PR is just for 5k points and 10k points) could/should be a message that would communicate thanks in a celebratory/congratulatory tone. Each is a milestone more than worthy for resting at, rather than a race to forty thousand points.

In a way, I like your initial suggestions more than the rewrites. They just could be more celebratory/congratulatory in nature.

Do you want to take another crack at the 5k and 10k messages?

}
if (points === 10000) {
return 'You know there is a world outside the Discord right?';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return 'You know there is a world outside the Discord right?';
return 'Quarter of the way there, only 30000 to go!';

}
return 'Woot!';
}

Expand Down