Update swift-syntax version and improve type constraints to resolve errors & warnings
#150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] Bumped `swift-syntax` dependency to allow up to `603.0.0`. - [x] Added `SendableMetatype` constraint to `NumberCodingStrategy` extension. - [x] Refactored `caseEncodeExpr` in `EnumVariable` for consistent `FunctionCallExprSyntax` usage.
- [x] Corrected indentation for the `caseEncodeExpr` closure to maintain consistent formatting.
There was a problem hiding this comment.
Pull request overview
This PR updates the swift-syntax dependency to support versions up to 603.0.0 and addresses breaking API changes introduced in newer versions of the library.
- Updated
swift-syntaxversion range from"509.1.0"..<"602.0.0"to"509.1.0"..<"603.0.0" - Refactored
FunctionCallExprSyntaxinitialization to usecalledExpression:parameter instead of deprecatedcallee: - Added
SendableMetatypeconstraint toValueCodingStrategyextension for number types
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Package.swift | Bumped swift-syntax dependency upper bound to 603.0.0 |
| Sources/PluginCore/Variables/Type/EnumVariable.swift | Updated FunctionCallExprSyntax API usage from callee: to calledExpression: for consistency |
| Sources/HelperCoders/ValueCoders/Number.swift | Added SendableMetatype constraint to ValueCodingStrategy extension |
Replaces the `SendableMetatype` constraint with `Sendable` in the `ValueCodingStrategy` extension to align with updated protocol requirements or type definitions.
- [x] Refactors `caseEncodeExpr` to return only the case name for enum cases without associated values, avoiding unnecessary parentheses. This improves code generation for enums with simple cases.
- [x] Update `ConformEncodableTests.misuseWithCodable` to expect four diagnostics. - [x] Ensure diagnostic IDs, messages, fix-its, and line/column positions match emitted results: - [x] Two diagnostics for `@ConformEncodable` at line 1, column 1. - [x] Two diagnostics for `@Codable` at line 2, column 1. - [x] Mirrors the pattern already used in `misuseWithDecodable`.
Comment on lines
+41
to
+49
| .init( | ||
| id: Codable.misuseID, | ||
| message: | ||
| "@Codable can't be used in combination with @ConformEncodable", | ||
| line: 2, column: 1, | ||
| fixIts: [ | ||
| .init(message: "Remove @Codable attribute") | ||
| ] | ||
| ), |
There was a problem hiding this comment.
This diagnostic entry appears to be a duplicate of the diagnostic at lines 59-67. Both have the same id (Codable.misuseID), message, line, column, and fixIt. Consider removing this duplicate entry to avoid test redundancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates dependencies, improves enum case encoding logic, enhances protocol constraints for numeric value coders, and adds a new test for attribute misuse. The changes focus on compatibility, correctness, and improved diagnostics.
Dependency update:
swift-syntaxpackage dependency to allow versions up to603.0.0, ensuring compatibility with newer releases.Enum encoding logic improvements:
EnumVariableso that cases without associated values are encoded as just the case name, without parentheses, improving the correctness of generated code.Protocol constraint enhancement:
Sendableconstraint to the generic requirements for numeric value coding strategies, improving safety for concurrent use.Testing and diagnostics:
ConformEncodableTeststo check for misuse when@Codableis used in combination with@ConformEncodable, providing better diagnostics for attribute conflicts.