Skip to content

fix(qwik-city): remove doubling of assetDir on postBuild #8152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −2
Open

fix(qwik-city): remove doubling of assetDir on postBuild #8152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
193b0ed
fix(qwik-city): remove doubling of assetDir on postBuild
intellix Nov 13, 2025
e21c487
Merge branch 'main' into v1-assets-dir-static-files
intellix Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/deep-bushes-live.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@builder.io/qwik-city': minor
---

remove double assetsDir on bundle close of staticPaths
4 changes: 2 additions & 2 deletions packages/qwik-city/src/adapters/shared/vite/post-build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ export async function postBuild(
}
};

const loadDir = async (fsDir: string, pathname: string) => {
const loadDir = async (fsDir: string, pathname = '') => {
const itemNames = await fs.promises.readdir(fsDir);
await Promise.all(itemNames.map((i) => loadItem(fsDir, i, pathname)));
};

if (fs.existsSync(clientOutDir)) {
await loadDir(clientOutDir, pathName);
await loadDir(clientOutDir);
}

const notFoundPathsCode = createNotFoundPathsModule(pathName, notFounds, format);
Expand Down
Loading