Skip to content

Conversation

@JPrevost
Copy link
Member

@JPrevost JPrevost commented Dec 15, 2025

Why are these changes being introduced:

  • This information is arguably more important on no results pages than on regular results pages, as users may need more guidance

Relevant ticket(s):

How does this address that need:

  • Adds results_callouts partial to no results section of display logic

Document any side effects to this change:

  • This partial shows up in two places. A comment has been added to note this to make future changes easier reason about.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why are these changes being introduced:

* This information is arguably more important on no results pages than
  on regular results pages, as users may need more guidance

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/USE-280

How does this address that need:

* Adds `results_callouts` partial to no results section of display logic

Document any side effects to this change:

* This partial shows up in two places. A comment has been added to note
  this to make future changes easier reason about.
@coveralls
Copy link

coveralls commented Dec 15, 2025

Pull Request Test Coverage Report for Build 20248136822

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.906%

Totals Coverage Status
Change from base Build 20236665931: 0.0%
Covered Lines: 1169
Relevant Lines: 1194

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-280-he-cobl8p December 15, 2025 20:56 Inactive
@jazairi jazairi self-assigned this Dec 15, 2025
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier than I feared! 🙂

@JPrevost JPrevost temporarily deployed to timdex-ui-pi-use-280-he-cobl8p December 15, 2025 21:32 Inactive
@JPrevost JPrevost merged commit cba9e80 into main Dec 15, 2025
5 checks passed
@JPrevost JPrevost deleted the use-280-help-boxes-no-results branch December 15, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants