USE-271: Add No Results content to USE

[djanelle-mit]

Developer

This work adds the "No results" content that helps orient a user to alternative search methods.

Accessibility

• ANDI or WAVE has been run in accordance to our guide.
• This PR contains no changes to the view layer.
• New issues flagged by ANDI or WAVE have been resolved.
• New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
• No new accessibility issues have been flagged.

New ENV

• All new ENV is documented in README.
• All new ENV has been added to Heroku Pipeline, Staging and Prod.
• ENV has not changed.

Approval beyond code review

• UXWS/stakeholder approval has been confirmed.
• UXWS/stakeholder review will be completed retroactively.
• UXWS/stakeholder review is not needed.

Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code

• I have confirmed that the code works as intended.
• Any CodeClimate issues have been fixed or confirmed as
  added technical debt.

Documentation

• The commit message is clear and follows our guidelines
  (not just this pull request message).
• The documentation has been updated or is unnecessary.
• New dependencies are appropriate or there were no changes.

Testing

• There are appropriate tests covering any new functionality.
• No additional test coverage is required.

[coveralls]

Pull Request Test Coverage Report for Build 20136792838

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.142%

---

Totals
Change from base Build 20112755264:	0.0%
Covered Lines:	1109
Relevant Lines:	1130

---

💛 - Coveralls

[matt-bernhardt]

My only engineering question is why we're introducing a no_results partial rather than putting the content directly into the results.html.erb template. Are we on a path to re-using the no-results text in another context?

I'm approving this either way, to be clear - but wasn't sure whether there are plans I haven't seen yet.

[djanelle-mit]

My only engineering question is why we're introducing a no_results partial rather than putting the content directly into the results.html.erb template. Are we on a path to re-using the no-results text in another context?

I'm approving this either way, to be clear - but wasn't sure whether there are plans I haven't seen yet.

@matt-bernhardt Fair point! I didn't have a particular use case yet for using it in multiple places. It felt easier to comprehend when it's in it's own context. Do you think this is a case where we should lean away from modularization? I could absolutely also see an argument that it's harder to track down what that content is. On the other hand, most of the content in the results view is delivered via a partial so it sort of feels like having this in a partial, even when not yet reused, is parity with other blocks of content.