Remove cookies for active tab #305
Merged
+13
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: UXWS has determined that the 'sticky tab' behavior is frustrating in practice, and would prefer instead that the application identify the current tab based on params. Relevant ticket(s): - [USE-228](https://mitlibraries.atlassian.net/browse/USE-228) How this addresses that need: This refactors the `set_active_tab` method to check for the presence of `params[:tab]`. If that exists, it uses it as the active tab; if not, it defaults to 'all'. Side effects of this change: None.
jazairi
force-pushed
the
use-228-revert-tab-cookies
branch
from
1a2d252 to
f3ab61c
Compare
Pull Request Test Coverage Report for Build 20114131911Details
💛 - Coveralls |
matt-bernhardt
approved these changes
Dec 11, 2025
Member
matt-bernhardt
left a comment
matt-bernhardt
left a comment
There was a problem hiding this comment.
Thanks - this works, and looks like a pretty clean removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
UXWS has determined that the 'sticky tab' behavior is frustrating in practice, and would prefer instead that the application identify the current tab based on params.
Relevant ticket(s):
How this addresses that need:
This refactors the
set_active_tabmethod to check for the presence ofparams[:tab]. If that exists, it uses it as the active tab; if not, it defaults to 'all'.Side effects of this change:
None.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
While reviewing, please confirm that the tests for this feature still make sense. I intentionally did not include a regression test to check for the presence of cookies, but I could if that would be useful.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing