-
Notifications
You must be signed in to change notification settings - Fork 87
Update README.md #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Update README.md #635
Conversation
Summary of ChangesHello @geoffreyjing, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the README.md to add a new cookbook for prompt comparisons. The changes are straightforward, but I have a couple of suggestions to improve formatting and consistency. One comment addresses excessive blank lines, and the other suggests aligning the new cookbook's link with the established structure for other cookbooks in the repository. Applying these suggestions will improve the document's readability and maintainability.
README.md
Outdated
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md
Outdated
| | Online ABM | [Research Agent](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/monitoring/Research_Agent_Online_Monitoring.ipynb) | Monitor agent behavior in production | | ||
| | Custom Scorers | [HumanEval](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/custom_scorers/HumanEval_Custom_Scorer.ipynb) | Build custom evaluators for your agents | | ||
| | Offline Testing | [Get Started For Free] | Compare how different prompts, models, or agent configs affect performance across ANY metric | | ||
| | Prompt Comparisons | [Customer Support Agent](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/JudgmentCustomScorer.ipynb) | Test and score customer support prompts to see which style performs best | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other cookbooks in the table, this notebook should be placed in a subdirectory that matches its category and have a filename that reflects its content. The current path and filename are inconsistent with the established pattern in this project. Please see the suggestion for a more consistent link.
| | Prompt Comparisons | [Customer Support Agent](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/JudgmentCustomScorer.ipynb) | Test and score customer support prompts to see which style performs best | | |
| | Prompt Comparisons | [Customer Support Agent](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/prompt_comparisons/Customer_Support_Agent.ipynb) | Test and score customer support prompts to see which style performs best | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do this
Removed extra blank lines in README.md
JCamyre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check gemini comment
README.md
Outdated
| | Online ABM | [Research Agent](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/monitoring/Research_Agent_Online_Monitoring.ipynb) | Monitor agent behavior in production | | ||
| | Custom Scorers | [HumanEval](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/custom_scorers/HumanEval_Custom_Scorer.ipynb) | Build custom evaluators for your agents | | ||
| | Offline Testing | [Get Started For Free] | Compare how different prompts, models, or agent configs affect performance across ANY metric | | ||
| | Prompt Comparisons | [Customer Support Agent](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/JudgmentCustomScorer.ipynb) | Test and score customer support prompts to see which style performs best | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do this
|
✔️ Propel has finished reviewing this change. |
JCamyre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requests
| | RL | [Wikipedia Racer](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/rl/WikiRacingAgent_RL.ipynb) | Train agents with reinforcement learning | | ||
| | Online ABM | [Research Agent](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/monitoring/Research_Agent_Online_Monitoring.ipynb) | Monitor agent behavior in production | | ||
| | Custom Scorers | [HumanEval](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/custom_scorers/HumanEval_Custom_Scorer.ipynb) | Build custom evaluators for your agents | | ||
| | Offline Testing | [Get Started For Free] | Compare how different prompts, models, or agent configs affect performance across ANY metric | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
- Comment the
Offline testingrow out - please make a Linear task to make one, assign to yourself for now - Make your
Customer_Support_Agent.ipynbnotebook public (i.e. share -> anyone with link can view)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the notebook should already be public, just tried opening it in an incognito tab and was able to see it
commented out offline testing
| | RL | [Wikipedia Racer](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/rl/WikiRacingAgent_RL.ipynb) | Train agents with reinforcement learning | | ||
| | Online ABM | [Research Agent](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/monitoring/Research_Agent_Online_Monitoring.ipynb) | Monitor agent behavior in production | | ||
| | Custom Scorers | [HumanEval](https://colab.research.google.com/github/JudgmentLabs/judgment-cookbook/blob/main/custom_scorers/HumanEval_Custom_Scorer.ipynb) | Build custom evaluators for your agents | | ||
| <!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Documentation]
The standalone HTML comment lines interrupt the Markdown table, so the new “Prompt Comparisons” row renders outside the table. Please move the comment onto a single line with the row (e.g., <!-- | Offline Testing ... | -->) or remove it so the table remains contiguous.
Context for Agents
[**Documentation**]
The standalone HTML comment lines interrupt the Markdown table, so the new “Prompt Comparisons” row renders outside the table. Please move the comment onto a single line with the row (e.g., `<!-- | Offline Testing ... | -->`) or remove it so the table remains contiguous.
File: README.md
Line: 64
📝 Summary
added prompt comparison cookbook
✅ Checklist