Skip to content

Fix 1415: observability_exclude_paths env parsing issue #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nmveeresh wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix 1415: observability_exclude_paths env parsing issue #1555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea673c4
Fix: observability_exclude_paths env parsing issue
nmveeresh Dec 5, 2025
7d6fb37
Fix: observability_exclude_paths env parsing issue
nmveeresh Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,28 +1198,28 @@ PAGINATION_INCLUDE_LINKS=true

# Enable observability tracing and metrics collection
# When enabled, all HTTP requests will be traced with detailed timing, status codes, and context
# OBSERVABILITY_ENABLED=false
OBSERVABILITY_ENABLED=false

# Automatically trace HTTP requests
# OBSERVABILITY_TRACE_HTTP_REQUESTS=true
OBSERVABILITY_TRACE_HTTP_REQUESTS=true

# Number of days to retain trace data
# OBSERVABILITY_TRACE_RETENTION_DAYS=7
OBSERVABILITY_TRACE_RETENTION_DAYS=7

# Maximum number of traces to retain (prevents unbounded growth)
# OBSERVABILITY_MAX_TRACES=100000
OBSERVABILITY_MAX_TRACES=100000

# Trace sampling rate (0.0-1.0) - 1.0 means trace everything, 0.1 means trace 10%
# OBSERVABILITY_SAMPLE_RATE=1.0
OBSERVABILITY_SAMPLE_RATE=1.0

# Paths to exclude from tracing (comma-separated regex patterns)
# OBSERVABILITY_EXCLUDE_PATHS=/health,/healthz,/ready,/metrics,/static/.*
OBSERVABILITY_EXCLUDE_PATHS='["/health", "/healthz", "/ready", "/metrics", "/static/.*"]'

# Enable metrics collection
# OBSERVABILITY_METRICS_ENABLED=true
OBSERVABILITY_METRICS_ENABLED=true

# Enable event logging within spans
# OBSERVABILITY_EVENTS_ENABLED=true
OBSERVABILITY_EVENTS_ENABLED=true

#####################################
# Ed25519 Key Support
Expand Down
3 changes: 2 additions & 1 deletion mcpgateway/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,7 @@ def _parse_allowed_origins(cls, v: Any) -> Set[str]:
observability_sample_rate: float = Field(default=1.0, ge=0.0, le=1.0, description="Trace sampling rate (0.0-1.0)")

# Exclude paths from tracing (regex patterns)
observability_exclude_paths: List[str] = Field(default_factory=lambda: ["/health", "/healthz", "/ready", "/metrics", "/static/.*"], description="Paths to exclude from tracing (regex)")
observability_exclude_paths: List[str] = Field(default_factory=lambda: ["/health", "/healthz", "/ready", "/metrics", "/static/.*"], description="Paths to exclude from tracing")

# Enable performance metrics
observability_metrics_enabled: bool = Field(default=True, description="Enable metrics collection")
Expand Down Expand Up @@ -1102,6 +1102,7 @@ def _auto_enable_security_txt(cls, v: Any, info: ValidationInfo) -> bool:
"sso_auto_admin_domains",
"sso_github_admin_orgs",
"sso_google_admin_domains",
"observability_exclude_paths",
mode="before",
)
@classmethod
Expand Down
Loading