Fix for issue #256 relating to the strike modal features. #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to setStrikeToEdit when adding a new strike and clearing the form after adding a strike.
HackYourFutures
temporarily deployed
to
dojo-frontend-strikemod-ltqme3
hyf-trainee-1
approved these changes
Oct 29, 2025
stasel
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #256 relating to the strike modal features.
For #256 , the solution is to pass a flag to let the strike modal know that editing is different than adding a strike. This is done by passing a null value for the
strikeToEditproperty. Furthermore, using theresetForm()function cleans up the form after adding a new strike.Finally, minor margin changes were added for a better fitting list.