-
Notifications
You must be signed in to change notification settings - Fork 5k
Bugfix/media upload failed on all hosts #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Bugfix/media upload failed on all hosts #2240
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider refactoring the duplicated protocol constants and agent‐selection switch logic into a shared helper to avoid code duplication between makeProxyAgent and makeProxyAgentUndici.
- selectProxyAgent adds socks5 support but doesn’t handle socks4 protocol—add PROXY_SOCKS4_PROTOCOL and a case for it for consistency with makeProxyAgentUndici.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider refactoring the duplicated protocol constants and agent‐selection switch logic into a shared helper to avoid code duplication between makeProxyAgent and makeProxyAgentUndici.
- selectProxyAgent adds socks5 support but doesn’t handle socks4 protocol—add PROXY_SOCKS4_PROTOCOL and a case for it for consistency with makeProxyAgentUndici.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Please fix the conflicts, OK? |
…oad-failed-on-all-hosts # Conflicts: # package-lock.json # src/utils/makeProxyAgent.ts
@DavidsonGomes Conflitos resolvidos, agora as proxies do tipo socks devem funcionar corretamente! |
📋 Description
Correção no uso de proxy socks dentro do axios
🔗 Related Issue
Closes #(issue_number)
🧪 Type of Change
🧪 Testing
📸 Screenshots (if applicable)
✅ Checklist
📝 Additional Notes