Hlsl path tracer #224
Open
Hlsl path tracer #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
45
to
46
| NBL_CONSTEXPR uint32_t MAX_DEPTH_LOG2 = 4; | ||
| NBL_CONSTEXPR uint32_t MAX_SAMPLES_LOG2 = 10; |
Member
Author
There was a problem hiding this comment.
shared header!
Comment on lines
17
to
36
| #ifdef SPHERE_LIGHT | ||
| #define SPHERE_COUNT 9 | ||
| #define TRIANGLE_COUNT 0 | ||
| #define RECTANGLE_COUNT 0 | ||
| #endif | ||
|
|
||
| #ifdef TRIANGLE_LIGHT | ||
| #define TRIANGLE_COUNT 1 | ||
| #define SPHERE_COUNT 8 | ||
| #define RECTANGLE_COUNT 0 | ||
| #endif | ||
|
|
||
| #ifdef RECTANGLE_LIGHT | ||
| #define RECTANGLE_COUNT 1 | ||
| #define SPHERE_COUNT 8 | ||
| #define TRIANGLE_COUNT 0 | ||
| #endif | ||
|
|
||
| #define LIGHT_COUNT 1 | ||
| #define BXDF_COUNT 7 |
Member
Author
There was a problem hiding this comment.
want this baked in STATIC_INLINE_CONSTEXPR in 3 different scenes
Comment on lines
49
to
58
| constexpr static inline uint32_t2 WindowDimensions = { 1280, 720 }; | ||
| constexpr static inline uint32_t MaxFramesInFlight = 5; | ||
| constexpr static inline clock_t::duration DisplayImageDuration = std::chrono::milliseconds(900); | ||
| constexpr static inline uint32_t DefaultWorkGroupSize = 512u; | ||
| constexpr static inline uint32_t MaxDescriptorCount = 256u; | ||
| constexpr static inline uint32_t MaxDepthLog2 = 4u; // 5 | ||
| constexpr static inline uint32_t MaxSamplesLog2 = 10u; // 18 | ||
| constexpr static inline uint32_t MaxBufferDimensions = 3u << MaxDepthLog2; | ||
| constexpr static inline uint32_t MaxBufferSamples = 1u << MaxSamplesLog2; | ||
| constexpr static inline uint8_t MaxUITextureCount = 1u; |
Member
Author
There was a problem hiding this comment.
lot of this stuff should be in shared header between HLSL and C++
…htracer doesn't need create params
…params into render_common
# Conflicts: # 31_HLSLPathTracer/app_resources/hlsl/common.hlsl # 31_HLSLPathTracer/app_resources/hlsl/render.comp.hlsl # 31_HLSLPathTracer/app_resources/hlsl/render_common.hlsl # 31_HLSLPathTracer/app_resources/hlsl/render_rwmc_common.hlsl # 31_HLSLPathTracer/app_resources/hlsl/scene.hlsl # 31_HLSLPathTracer/main.cpp
…xis scaling for triangle and rectangle
…lights # Conflicts: # 31_HLSLPathTracer/app_resources/hlsl/render.comp.hlsl # 31_HLSLPathTracer/app_resources/hlsl/scene.hlsl # 31_HLSLPathTracer/main.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keptsecret after you merge
masteragain, you'll probably have the UI mess up and show changed from the merge commit, so close and reopen again