Skip to content

feat: add ETag to track the changed status of an object on the server #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: add ETag to track the changed status of an object on the server #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
43e44ca
feat: add ETag to track the changed status of an object on the server
Nov 21, 2025
4991172
feat: refactor testcase and import
Nov 21, 2025
62f92ba
feat: add test cases for etag enabling and disabling
Nov 21, 2025
eaa2874
feat: add allow(clippy::needless_return)
Nov 21, 2025
f87ff65
feat: update comments for http code
Nov 21, 2025
4fe962b
feat: update comments format
Nov 21, 2025
87469e4
feat: remove redundant libs
Nov 22, 2025
b5d35bf
feat: erasure redundant commments
Nov 22, 2025
e6949b4
feat: erasure redundant commments
Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions infera/Cargo.toml
View file
Open in desktop
Copy link
Member

@habedi habedi Nov 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these libraries (added in the infera/Cargo.toml) needed as main dependencies? It seems to me they are needed for tests.

Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ sha2 = "0.10"
hex = "0.4"
filetime = "0.2"

tokio = { version = "1", features = ["full"] }
Copy link
Member

@habedi habedi Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need tokio, especially with all of its features enabled. I think, at the moment, Infera itself doesn't do anything that requires an async IO runtime.

tokio-util = "0.7" # for ReaderStream
actix-middleware-etag = "0.4.6"
actix-web = "4.12.0"
bytes = "1.11.0"

[dev-dependencies]
tempfile = "3.10"
mockito = "1.7.0"
Expand Down
Loading
Loading