COMP: Fix MSVC template warnings #1474
Open
+69
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
force-pushed
the
topic/fix_misc_template_warnings
branch
4 times, most recently
from
f29027b to
52d54f8
Compare
imikejackson
force-pushed
the
topic/fix_misc_template_warnings
branch
from
52d54f8 to
8ff0db0
Compare
JDuffeyBQ
reviewed
Dec 3, 2025
|
|
||
| // Convert the misorientation to Degrees and store the value | ||
| currentMisalignmentList[j] = w * Constants::k_180OverPiD; | ||
| currentMisalignmentList[j] = static_cast<float32>(w * Constants::k_180OverPiF); |
Collaborator
There was a problem hiding this comment.
Here k_180OverPiF gets promoted to float64 due to w so I think keeping it as k_180OverPiD is ok.
| } | ||
|
|
||
| void compute(usize start, usize end) const | ||
| void compute(size_t start, size_t end) const |
Collaborator
There was a problem hiding this comment.
usize should be the same as size_t. Was there a warning here?
| summationValue += value; | ||
| if constexpr(std::is_same_v<T, bool>) | ||
| { | ||
| summationValue = value == true ? true : false; |
Collaborator
There was a problem hiding this comment.
This is the same as summationValue = value. But is this what we want to do here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC Compiler warnings due to possible template type usage and converting between them. This PR attempts to fix the warnings by fixing the code.