Require Android users on pre-16.2.96 releases to upgrade. #10957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will facilitate adding a bunch more test cases shortly.
This release is from 2018-08-22, a little over 100 days ago. It was the first release with the important fix so that when the server advises it to stop displaying a notification because the user has read the message (as the SEND_REMOVE_PUSH_NOTIFICATIONS server setting enables), the app doesn't instead replace the notification with a broken one reading "null". We have that setting running now on chat.zulip.org, and intend to roll it out more broadly soon. The `# take 0` thing is a slightly absurd workaround for the fact that our funky out-of-line way of marking lines to ignore doesn't work right if there are multiple such lines in a given file that are equal modulo leading and trailing whitespace.
In a quick scan of today's nginx logs on chat.zulip.org, there were 20 distinct user-agents that begin with 'ZulipMobile/'. Here's a representative sampling of them, such that the rest were all boringly similar to one of these. First, to make room for these without an excess of copy-paste and overlong lines, convert this test to a data-oriented style. The existing, synthetic cases appear in the new data followed by the seen-in-the-wild cases. Happily, the code being tested passes all these new cases unchanged.
gnprice
force-pushed
the
compatibility
branch
from
b0bd29e to
d8bf932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable us to roll out "remove notification when read" (zulip/zulip-mobile#3119) to all Android users.