streams: Add UI warnings for failing events.

Fixes #816

Author: Abhirup-99

tests/model/test_model.py

@@ -2116,6 +2116,30 @@ def test_is_user_subscribed_to_stream(self, model, stream_dict, stream_id,
 
         assert return_value == expected_response
 
+    @pytest.mark.parametrize('stream_id, expected_response,', [
+            (100, False),
+            (101, False),
+            (3, True),
+        ],
+        ids=[
+            'subscribed_pinned_stream',
+            'subscribed_unpinned_stream',
+            'unsubscribed_stream',
+        ]
+    )
+    def test_is_user_in_unsubscribed_stream(self, model, stream_dict,
+                                            stream_id, expected_response,
+                                            initial_pinned_streams,
+                                            initial_unpinned_streams):
+
+        model.pinned_streams = deepcopy(initial_pinned_streams)
+        model.unpinned_streams = deepcopy(initial_unpinned_streams)
+        return_value = model.is_user_in_unsubscribed_stream(stream_id)
+
+        assert model.pinned_streams == initial_pinned_streams
+        assert model.unpinned_streams == initial_unpinned_streams
+        assert return_value == expected_response
+
     @pytest.mark.parametrize('response', [{
         'result': 'success',
         'msg': '',

tests/ui/test_ui_tools.py

@@ -74,6 +74,7 @@ def mock_external_classes(self, mocker):
         self.model = mocker.MagicMock()
         self.view = mocker.Mock()
         self.urwid = mocker.patch(VIEWS + ".urwid")
+        self.model.is_user_in_unsubscribed_stream.return_value = False
 
     @pytest.fixture
     def msg_view(self, mocker, msg_box):
@@ -811,6 +812,7 @@ def mock_external_classes(self, mocker):
         self.super = mocker.patch(VIEWS + '.urwid.Frame.__init__')
         self.super_keypress = mocker.patch(VIEWS + '.urwid.Frame.keypress')
         self.model.controller == mocker.Mock()
+        self.model.is_user_in_unsubscribed_stream.return_value = False
 
     @pytest.fixture
     def mid_col_view(self):
@@ -1259,6 +1261,7 @@ class TestMessageBox:
     def mock_external_classes(self, mocker, initial_index):
         self.model = mocker.MagicMock()
         self.model.index = initial_index
+        self.model.is_user_in_unsubscribed_stream.return_value = False
 
     @pytest.mark.parametrize('message_type, set_fields', [
         ('stream',

tests/ui_tools/test_boxes.py

@@ -14,6 +14,7 @@ class TestWriteBox:
     def mock_external_classes(self, mocker, initial_index):
         self.view = mocker.Mock()
         self.view.model = mocker.Mock()
+        self.view.model.is_user_in_unsubscribed_stream.return_value = False
 
     @pytest.fixture()
     def write_box(self, mocker, users_fixture, user_groups_fixture,

zulipterminal/model.py

@@ -718,6 +718,9 @@ def stream_id_from_name(self, stream_name: str) -> int:
     def is_pinned_stream(self, stream_id: int) -> bool:
         return stream_id in [stream['id'] for stream in self.pinned_streams]
 
+    def is_unpinned_stream(self, stream_id: int) -> bool:
+        return stream_id in [stream['id'] for stream in self.unpinned_streams]
+
     def toggle_stream_pinned_status(self, stream_id: int) -> bool:
         request = [{
             'stream_id': stream_id,
@@ -730,6 +733,10 @@ def toggle_stream_pinned_status(self, stream_id: int) -> bool:
     def is_user_subscribed_to_stream(self, stream_id: int) -> bool:
         return stream_id in self.stream_dict
 
+    def is_user_in_unsubscribed_stream(self, stream_id: int) -> bool:
+        return not(self.is_pinned_stream(stream_id)
+                   or self.is_unpinned_stream(stream_id))
+
     def make_reduced_stream_data(self, stream: Any) -> StreamData:
         # stream_id has been changed to id.
         return StreamData({'name': stream['name'],

zulipterminal/ui_tools/boxes.py

@@ -1133,6 +1133,11 @@ def keypress(self, size: urwid_Size, key: str) -> Optional[str]:
                     stream_id=self.stream_id,
                 )
         elif is_command_key('STREAM_MESSAGE', key):
+            if(self.model.is_user_in_unsubscribed_stream(self.stream_id)):
+                self.model.controller.view.set_footer_text(
+                        " You can't write messages to unsubscribed streams.",
+                        3)
+                return None
             if self.message['type'] == 'private':
                 self.model.controller.view.write_box.private_box_view(
                     email=self.recipients_emails,
@@ -1177,13 +1182,18 @@ def keypress(self, size: urwid_Size, key: str) -> Optional[str]:
                 recipient_user_ids=[self.message['sender_id']],
             )
         elif is_command_key('MENTION_REPLY', key):
-            self.keypress(size, 'enter')
-            mention = '@**' + self.message['sender_full_name'] + '** '
-            self.model.controller.view.write_box.msg_write_box.set_edit_text(
-                mention)
-            self.model.controller.view.write_box.msg_write_box.set_edit_pos(
-                len(mention))
-            self.model.controller.view.middle_column.set_focus('footer')
+            if(not self.model.is_user_in_unsubscribed_stream(self.stream_id)):
+                self.keypress(size, 'enter')
+                mention = '@**' + self.message['sender_full_name'] + '** '
+                write_box = self.model.controller.view.write_box.msg_write_box
+                write_box.set_edit_text(mention)
+                write_box.set_edit_pos(len(mention))
+                self.model.controller.view.middle_column.set_focus('footer')
+            else:
+                self.model.controller.view.set_footer_text(
+                    " You can't reply to messages from unsubscribed streams.",
+                    3)
+                return key
         elif is_command_key('QUOTE_REPLY', key):
             self.keypress(size, 'enter')
             quote = '```quote\n' + self.model.client.get_raw_message(

zulipterminal/ui_tools/views.py

@@ -538,13 +538,22 @@ def keypress(self, size: urwid_Size, key: str) -> Optional[str]:
             return key
 
         elif is_command_key('STREAM_MESSAGE', key):
+            if(self.model.is_user_in_unsubscribed_stream(
+               self.model.stream_id)):
+                self.model.controller.view.set_footer_text(
+                        " You can't write messages from unsubscribed streams.",
+                        3)
+                return None
             self.body.keypress(size, 'c')
+
             # For new streams with no previous conversation.
             if self.footer.focus is None:
                 stream_id = self.model.stream_id
                 stream_dict = self.model.stream_dict
                 self.footer.stream_box_view(
-                    caption=stream_dict[stream_id]['name'])
+                    caption=stream_dict[stream_id]['name'],
+                    stream_id=stream_id
+                    )
             self.set_focus('footer')
             self.footer.focus_position = 0
             return key