Skip to content

Replace "Share" with "Copy link to message" #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gnprice opened this issue Jun 4, 2018 · 5 comments · May be fixed by #3865
Open

Replace "Share" with "Copy link to message" #2623

gnprice opened this issue Jun 4, 2018 · 5 comments · May be fixed by #3865
Assignees
@chrisbobbe
Labels
a-message list a-share-from Sharing from Zulip to other apps help wanted webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@gnprice
Copy link
Member

gnprice commented Jun 4, 2018

When I'm looking at a Zulip message and want to share it with someone, sometimes I want to send them a copy of the message's contents; and sometimes I want to send them a link so they can read the whole conversation around it, when I know they have access to see it.

Currently we don't provide the "link to this message" feature. We should add it to the long-press menu. The simple way to do this is an option labeled "Copy link to message", which just puts a link on the clipboard.

It can replace the "Share" option -- that option doesn't currently add a ton of value, because it just copies the text of the message into another app. (In some apps, a "share" option shares a link to the thing being shared. But that works a lot better when all the data is public, and anyone you share it with can follow the link.)
@jainkuniya
Copy link
Member

Instead of replacing it with Share, can we add Copy link to message.
Many time we need to share message to others via other app or save that message (mostly when that message is most probably context free like it contains imp link or something). So in such situations Share will be useful.
Just checked in Slack, they provide three options Copy Message, Copy Link to message and Share.

BTW Slack works differently for the Share option.

@zulipbot claim

@armaanahluwalia
Copy link
Collaborator

I just faced this issue. I feel like this would be a great UX improvement. At least for the use-case of being able to reference one conversation from another within the app.

ishammahajan added a commit to ishammahajan/zulip-mobile that referenced this issue Mar 17, 2019
@ishammahajan
messageActionSheet: Add option to copy link of message to clipboard
b969f0b 
There are use cases where a person wants to share a message with others 
who he knows have access to a particular stream. To resolve this, in this 
commit, another option is added in the action sheet which shows up when
 a message is long pressed, which  copies the link of the message to the 
Clipboard.

I am concerned as to whether I should include tests for either of the files 
since I don't see any cases where something could go wrong. I have included
 translation for only English for now, because I wanted to make sure
 everything else is correct. I have also amended the `share` functionality 
to include a sweet little message which contains the link to the stream to 
make it more useful. Please advise on both the tests and this.

Fixes zulip#2623
This was referenced Mar 17, 2019
Closed
Closed
ishammahajan added a commit to ishammahajan/zulip-mobile that referenced this issue Mar 22, 2019
@ishammahajan
messageActionSheet: Add option to copy link of message to clipboard
dbc83fc 
There are use cases where a person wants to share a message with others
who he knows have access to a particular stream. To resolve this, in this
commit, another option is added in the action sheet which shows up when
 a message is long pressed, which  copies the link of the message to the
Clipboard.

I have amended the `share` functionality to include a sweet little message
which contains the link to the stream to make it more useful. I also have added
tests for the function `getLinkToMessage`.

Fixes zulip#2623
ishammahajan added a commit to ishammahajan/zulip-mobile that referenced this issue Mar 23, 2019
@ishammahajan
messageActionSheet: Add option to copy link of message to clipboard.
de1ab58 
There are use cases where a person wants to share a message with others
who he knows have access to a particular stream. To resolve this, in this
commit, another option is added in the action sheet which shows up when
 a message is long pressed, which  copies the link of the message to the
Clipboard.

I have edited the buttons to say `Copy message content` for copying their
content to the clipboard, and `Copy message link` to copy links which lead
to the message. I also have added tests for `getLinkToMessage`, a function
which provides a link to a particular message.

Fixes zulip#2623
ishammahajan added a commit to ishammahajan/zulip-mobile that referenced this issue Apr 6, 2019
@ishammahajan
messageActionSheet: Add option to copy link of message to clipboard.
129d770 
There are use cases where a person wants to share a message with others
who he knows have access to a particular stream. To resolve this, in this
commit, another option is added in the action sheet which shows up when
 a message is long pressed, which  copies the link of the message to the
Clipboard.

I have edited the buttons to say `Copy message content` for copying their
content to the clipboard, and `Copy message link` to copy links which lead
to the message. I also have added tests for `getLinkToMessage`, a function
which provides a link to a particular message.

Fixes zulip#2623
ishammahajan added a commit to ishammahajan/zulip-mobile that referenced this issue Apr 6, 2019
@ishammahajan
messageActionSheet: Add option to copy link of message to clipboard.
fd7a9a0 
There are use cases where a person wants to share a message with others
who he knows have access to a particular stream. To resolve this, in this
commit, another option is added in the action sheet which shows up when
 a message is long pressed, which  copies the link of the message to the
Clipboard.

I have edited the buttons to say `Copy message content` for copying their
content to the clipboard, and `Copy message link` to copy links which lead
to the message. I also have added tests for `getLinkToMessage`, a function
which provides a link to a particular message.

Fixes zulip#2623
ishammahajan added a commit to ishammahajan/zulip-mobile that referenced this issue Jun 23, 2019
@ishammahajan
messageActionSheet: Add option to copy link of message to clipboard.
4a3bd46 
There are use cases where a person wants to share a message with others
who he knows have access to a particular stream. To resolve this, in this
commit, another option is added in the action sheet which shows up when
 a message is long pressed, which  copies the link of the message to the
Clipboard.

I have edited the buttons to say `Copy message content` for copying their
content to the clipboard, and `Copy message link` to copy links which lead
to the message. This commit uses the function introduced in its
parent in order to find the link of the message.

Fixes zulip#2623
ishammahajan added a commit to ishammahajan/zulip-mobile that referenced this issue Jul 1, 2019
@ishammahajan
messageActionSheet: Add option to copy link of message to clipboard.
211520e 
There are use cases where a person wants to share a message with others
who he knows have access to a particular stream. To resolve this, in this
commit, another option is added in the action sheet which shows up when
 a message is long pressed, which  copies the link of the message to the
Clipboard.

I have edited the buttons to say `Copy message content` for copying their
content to the clipboard, and `Copy message link` to copy links which lead
to the message. This commit uses the function introduced in its
parent in order to find the link of the message.

Fixes zulip#2623
ishammahajan added a commit to ishammahajan/zulip-mobile that referenced this issue Aug 17, 2019
@ishammahajan
messageActionSheet: Add option to copy link of message to clipboard.
2086e1e 
There are use cases where a person wants to share a message with others
who he knows have access to a particular stream. To resolve this, in this
commit, another option is added in the action sheet which shows up when
 a message is long pressed, which  copies the link of the message to the
Clipboard.

I have edited the buttons to say `Copy message content` for copying their
content to the clipboard, and `Copy message link` to copy links which lead
to the message. This commit uses the function introduced in its
parent in order to find the link of the message.

Fixes zulip#2623
@chrisbobbe
Copy link
Contributor

Is progress on this blocked by #3757? If there’s an easy path to supporting this, even before the web app code is shared, it would be good; there have been more requests, at — well, on chat.zulip.org; I’ll link to the message tomorrow, when I’ve got the web app open. 😉

@chrisbobbe chrisbobbe assigned chrisbobbe and unassigned jainkuniya Feb 3, 2020
chrisbobbe pushed a commit to chrisbobbe/zulip-mobile that referenced this issue Feb 3, 2020
@ishammahajan
messageActionSheet: Add option to copy link of message to clipboard.
bb88b3e 
There are use cases where a person wants to share a message with others
who he knows have access to a particular stream. To resolve this, in this
commit, another option is added in the action sheet which shows up when
 a message is long pressed, which  copies the link of the message to the
Clipboard.

I have edited the buttons to say `Copy message content` for copying their
content to the clipboard, and `Copy message link` to copy links which lead
to the message. This commit uses the function introduced in its
parent in order to find the link of the message.

Fixes zulip#2623
@gnprice
Copy link
Member Author

gnprice commented Feb 3, 2020

Is progress on this blocked by #3757?

Nope, I wouldn't block this on that.

If you haven't already, it'd be useful to look at the corresponding webapp code for constructing a link -- that's hash_util.operators_to_hash and its helpers. It'd be good for our implementation to be structured in parallel to that one, to the extent it makes sense to do so, in order to make sharing easier in the future. But one thing you'll see there is that that code calls out to other parts of the webapp to consult data structures about people and streams, which means it'll take some refactoring before it can be shared.

chrisbobbe pushed a commit to chrisbobbe/zulip-mobile that referenced this issue Feb 5, 2020
@ishammahajan
messageActionSheet: Add option to copy link to message to clipboard.
0649a48 
Use `getLinkToMessage`, introduced in the parent, to enable an
option, called 'Copy message link', from the message action sheet to
copy a link to the message to the clipboard. Preserve the option to
copy the message's content, but rename that to 'copy message
content.'

Fixes: zulip#2623.
@chrisbobbe chrisbobbe linked a pull request Feb 6, 2020 that will close this issue
messageActionSheet: Add option to copy link of message to clipboard #3865
Draft
@gnprice gnprice linked a pull request Feb 21, 2020 that will close this issue
Draft
chrisbobbe pushed a commit to chrisbobbe/zulip-mobile that referenced this issue Feb 28, 2020
@ishammahajan
messageActionSheet: Add option to copy link to message to clipboard.
9ef8226 
Use `getLinkToMessage`, introduced in the parent, to enable an
option, called 'Copy message link', from the message action sheet to
copy a link to the message to the clipboard. Preserve the option to
copy the message's content, but rename that to 'copy message
content.'

Fixes: zulip#2623.
@alya
Copy link
Collaborator

alya commented Jul 6, 2021

How close are we to being able to do this? It came up as something that would be very useful during our brainstorming session.

@gnprice gnprice mentioned this issue Jul 8, 2021
Closed
@gnprice gnprice added the a-share-from Sharing from Zulip to other apps label Oct 18, 2021
@alya alya added the webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. label Jan 3, 2022
@alya alya mentioned this issue Jun 8, 2022
Closed
@gnprice gnprice mentioned this issue May 14, 2024
Closed
@sm-sayedi sm-sayedi mentioned this issue Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
a-message list a-share-from Sharing from Zulip to other apps help wanted webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
None yet
Milestone
No milestone
6 participants
@gnprice @armaanahluwalia @alya @jainkuniya @chrisbobbe @zulipbot