Skip to content

deps: Reduce flutter_checks and legacy_checks to dev dependencies #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

PIG208
Copy link
Member

@PIG208 PIG208 commented Oct 11, 2024

They are only used in tests.

I was reminded of this by #917 (comment)

@PIG208 PIG208 requested a review from chrisbobbe October 11, 2024 18:27
@PIG208 PIG208 added the maintainer review PR ready for review by Zulip maintainers label Oct 11, 2024
They are only used in tests.

Signed-off-by: Zixuan James Li <[email protected]>
@gnprice gnprice merged commit e2df7a9 into zulip:main Oct 11, 2024
1 check passed
@gnprice
Copy link
Member

gnprice commented Oct 11, 2024

Thanks for cleaning that up! Merged with a tweak to make the commit message more specific:

-    deps: Make flutter_checks and legacy_checks direct dev dependencies
+    deps: Reduce flutter_checks and legacy_checks to dev dependencies

so that it's clear which direction the change is happening in — they used to be (direct) full dependencies, vs. used to be indirect (dev) dependencies.

@gnprice gnprice changed the title deps: Make flutter_checks and legacy_checks direct dev dependencies deps: Reduce flutter_checks and legacy_checks to dev dependencies Oct 11, 2024
@PIG208 PIG208 deleted the pr-deps branch October 11, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants