Skip to content

lightbox test: Add basic tests for image lightbox #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Jul 24, 2024

This includes several TODO comments for further aspects of the lightbox that this doesn't yet test.

/cc @rajveermalviya, for #833 (comment)

This includes several TODO comments for further aspects of the
lightbox that this doesn't yet test.
@gnprice gnprice added the maintainer review PR ready for review by Zulip maintainers label Jul 24, 2024
@gnprice gnprice requested a review from chrisbobbe July 24, 2024 07:03
@chrisbobbe chrisbobbe merged commit 6ee6ef2 into zulip:main Jul 24, 2024
1 check passed
@chrisbobbe
Copy link
Collaborator

Thanks, LGTM! Merged.

@gnprice gnprice deleted the pr-lightbox-test branch July 24, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants