Global Times #504
Merged
Global Times #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
reviewed
Feb 5, 2024
lib/model/content.dart
Outdated
| } | ||
|
|
||
| if (localName == 'time' && classes.isEmpty) { | ||
| final attr = element.attributes['datetime']; |
There was a problem hiding this comment.
nit:
Suggested change
| final attr = element.attributes['datetime']; | |
| final datetimeAttr = element.attributes['datetime']; |
lib/model/content.dart
Outdated
Comment on lines
747
to
752
| final DateTime datetime; | ||
| try { | ||
| datetime = DateTime.parse(attr); | ||
| } on FormatException { | ||
| return unimplemented(); | ||
| } |
There was a problem hiding this comment.
This can be cleaned up a bit using the tryParse method:
Suggested change
| final DateTime datetime; | |
| try { | |
| datetime = DateTime.parse(attr); | |
| } on FormatException { | |
| return unimplemented(); | |
| } | |
| final datetime = DateTime.tryParse(attr); | |
| if (datetime == null) return unimplemented(); |
test/model/content_test.dart
Outdated
|
|
||
| group('global times', () { | ||
| testParseInline('smoke', | ||
| // "<time:2024-01-30T17:33:00Z">" |
There was a problem hiding this comment.
Suggested change
| // "<time:2024-01-30T17:33:00Z">" | |
| // "<time:2024-01-30T17:33:00Z>" |
right?
| // borderRadius: BorderRadius.all(Radius.circular(3)))); | ||
| } | ||
|
|
||
| class GlobalTime extends StatelessWidget { |
There was a problem hiding this comment.
nit: put this after MessageImageEmoji, to match the if/else-if chain above (which matches the node-class definitions)
test/widgets/content_test.dart
Outdated
| tester.widget(find.text(r'\lambda')); | ||
| }); | ||
|
|
||
| testWidgets('GlobalTime smoke', (tester) async { |
There was a problem hiding this comment.
nit: put this after the MathInlineNode test below, to match the code under test in lib/widgets/content.dart
sirpengi
force-pushed
the
pr-globaltimes
branch
from
b3933e8 to
a952098
Compare
|
@gnprice ready for review again! |
Sourced today from: https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=164%3A10509&mode=dev Output was processed using inkscape to expand the strokes to paths and clean up unnecessary clipping. Also refer to discussion in CZO: https://chat.zulip.org/#narrow/stream/101-design/topic/clock.20icons/near/1728373
gnprice
force-pushed
the
pr-globaltimes
branch
from
a952098 to
e1bff3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #354